Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: ui/views/touchui/touch_editing_menu.cc

Issue 693583002: Expand quick menu buttons to fit their content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/touchui/touch_editing_menu.cc
diff --git a/ui/views/touchui/touch_editing_menu.cc b/ui/views/touchui/touch_editing_menu.cc
index 771bfb34b797cdc23dea203f884f5f7b7773e00e..bb9a7a645608c891661b0f541e80f819896f748e 100644
--- a/ui/views/touchui/touch_editing_menu.cc
+++ b/ui/views/touchui/touch_editing_menu.cc
@@ -16,7 +16,6 @@
#include "ui/views/bubble/bubble_frame_view.h"
#include "ui/views/controls/button/custom_button.h"
#include "ui/views/controls/button/label_button.h"
-#include "ui/views/controls/button/label_button_border.h"
#include "ui/views/layout/box_layout.h"
#include "ui/views/widget/widget.h"
@@ -27,8 +26,8 @@ const int kMenuCommands[] = {IDS_APP_CUT,
IDS_APP_PASTE};
const int kSpacingBetweenButtons = 2;
const int kButtonSeparatorColor = SkColorSetARGB(13, 0, 0, 0);
-const int kMenuButtonHeight = 38;
-const int kMenuButtonWidth = 63;
+const int kMenuButtonMinHeight = 38;
+const int kMenuButtonMinWidth = 63;
const int kMenuMargin = 1;
const char* kEllipsesButtonText = "...";
@@ -143,19 +142,14 @@ Button* TouchEditingMenuView::CreateButton(const base::string16& title,
int tag) {
base::string16 label = gfx::RemoveAcceleratorChar(title, '&', NULL, NULL);
LabelButton* button = new LabelButton(this, label);
+ button->SetMinSize(gfx::Size(kMenuButtonMinWidth, kMenuButtonMinHeight));
button->SetFocusable(true);
button->set_request_focus_on_press(false);
const gfx::FontList& font_list =
ui::ResourceBundle::GetSharedInstance().GetFontList(
ui::ResourceBundle::SmallFont);
- scoped_ptr<LabelButtonBorder> button_border(
- new LabelButtonBorder(button->style()));
- int v_border = (kMenuButtonHeight - font_list.GetHeight()) / 2;
- int h_border = (kMenuButtonWidth - gfx::GetStringWidth(label, font_list)) / 2;
- button_border->set_insets(
- gfx::Insets(v_border, h_border, v_border, h_border));
- button->SetBorder(button_border.Pass());
button->SetFontList(font_list);
+ button->SetHorizontalAlignment(gfx::ALIGN_CENTER);
button->set_tag(tag);
return button;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698