chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc - Issue 693523003: MacViews: Put wm window animation calls behind an interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

Issue 693523003: MacViews: Put wm window animation calls behind an interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@views-clipboard

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/autofill/autofill_popup_base_view.cc ('k') | chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc » ('j') | ui/views/widget/widget.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

index 50fad6c728aeca5fa67988279609d2264a7aafed..284c57d3a4ff662f7254943c01ebb80d8e3f5ef5 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

@@ -20,7 +20,6 @@

#include "ui/views/view_targeter.h"

#include "ui/views/widget/widget.h"

#include "ui/views/window/non_client_view.h"

-#include "ui/wm/core/window_animations.h"

// This is the number of pixels in the border image interior to the actual

// border.

@@ -214,8 +213,8 @@ void OmniboxPopupContentsView::UpdatePopupAppearance() {

// avoid a NULL dereference.

if (!popup_.get())

return;

- wm::SetWindowVisibilityAnimationTransition(

- popup_->GetNativeView(), wm::ANIMATE_NONE);

+ popup_->GetVisibilityAnimation()->SetTransition(

+ views::Widget::VisibilityAnimation::ANIMATE_NONE);

popup_->SetContentsView(this);

popup_->StackAbove(omnibox_view_->GetRelativeWindowForPopup());

if (!popup_.get()) {