chrome/browser/ui/views/autofill/autofill_popup_base_view.cc - Issue 693523003: MacViews: Put wm window animation calls behind an interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/autofill/autofill_popup_base_view.cc

Issue 693523003: MacViews: Put wm window animation calls behind an interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@views-clipboard

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/ui/login_display_host_impl.cc ('k') | chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc » ('j') | ui/views/widget/widget.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/autofill/autofill_popup_base_view.cc

diff --git a/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc b/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc

index ced38990ff6767f987a1b1b0563574168d155d8c..4494f8cc58423ed14add51ed24e850924813b56b 100644

--- a/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc

+++ b/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc

@@ -10,7 +10,6 @@

#include "chrome/browser/ui/autofill/popup_constants.h"

#include "ui/views/border.h"

#include "ui/views/widget/widget.h"

-#include "ui/wm/core/window_animations.h"

namespace autofill {

@@ -68,8 +67,8 @@ void AutofillPopupBaseView::DoShow() {

widget->SetContentsView(this);

// No animation for popup appearance (too distracting).

- wm::SetWindowVisibilityAnimationTransition(

- widget->GetNativeView(), wm::ANIMATE_HIDE);

+ widget->GetVisibilityAnimation()->SetTransition(

+ views::Widget::VisibilityAnimation::ANIMATE_HIDE);

}

SetBorder(views::Border::CreateSolidBorder(kPopupBorderThickness,