Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 693353002: Deprecate DOMImplementation.hasFeature() returning false (Closed)

Created:
6 years, 1 month ago by philipj_slow
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : semicolon #

Patch Set 3 : expectations #

Patch Set 4 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/required-feature-vs-has-feature.svg View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/required-feature-vs-has-feature-expected.svg View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/svg/custom/svg-features-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/DOMImplementation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
philipj_slow
semicolon
6 years, 1 month ago (2014-11-02 09:34:29 UTC) #1
philipj_slow
expectations
6 years, 1 month ago (2014-11-02 20:49:13 UTC) #2
philipj_slow
PTAL
6 years, 1 month ago (2014-11-05 05:27:47 UTC) #4
pdr.
@ed, does this address your concerns?
6 years, 1 month ago (2014-11-07 02:21:32 UTC) #6
philipj_slow
UseCounter for svg:requiredFeatures in https://codereview.chromium.org/712813002/
6 years, 1 month ago (2014-11-08 23:11:09 UTC) #7
Erik Dahlström (inactive)
On 2014/11/07 02:21:32, pdr wrote: > @ed, does this address your concerns? Well, I wouldn't ...
6 years, 1 month ago (2014-11-10 09:10:45 UTC) #8
philipj_slow
test
6 years, 1 month ago (2014-11-14 10:23:44 UTC) #9
philipj_slow
I've added required-feature-vs-has-feature.svg, PTAL.
6 years, 1 month ago (2014-11-14 10:24:14 UTC) #10
Erik Dahlström (inactive)
On 2014/11/14 10:24:14, philipj wrote: > I've added required-feature-vs-has-feature.svg, PTAL. Non-owner lgtm.
6 years, 1 month ago (2014-11-14 10:32:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693353002/60001
6 years, 1 month ago (2014-11-14 11:36:53 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 12:02:25 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 185367

Powered by Google App Engine
This is Rietveld 408576698