Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Side by Side Diff: Source/core/frame/UseCounter.cpp

Issue 693353002: Deprecate DOMImplementation.hasFeature() returning false (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: test Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/DOMImplementation.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 /* 2 /*
3 * Copyright (C) 2012 Google, Inc. All rights reserved. 3 * Copyright (C) 2012 Google, Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 801 matching lines...) Expand 10 before | Expand all | Expand 10 after
812 812
813 case ConsoleTimelineEnd: 813 case ConsoleTimelineEnd:
814 return "console.timelineEnd is deprecated. Please use the console.timeEn d instead."; 814 return "console.timelineEnd is deprecated. Please use the console.timeEn d instead.";
815 815
816 case XMLHttpRequestSynchronousInNonWorkerOutsideBeforeUnload: 816 case XMLHttpRequestSynchronousInNonWorkerOutsideBeforeUnload:
817 return "Synchronous XMLHttpRequest on the main thread is deprecated beca use of its detrimental effects to the end user's experience. For more help, chec k http://xhr.spec.whatwg.org/."; 817 return "Synchronous XMLHttpRequest on the main thread is deprecated beca use of its detrimental effects to the end user's experience. For more help, chec k http://xhr.spec.whatwg.org/.";
818 818
819 case FontFaceSetReady: 819 case FontFaceSetReady:
820 return "document.fonts.ready() method is going to be replaced with docum ent.fonts.ready attribute in future releases. Please be prepared. For more help, check https://code.google.com/p/chromium/issues/detail?id=392077#c3 ."; 820 return "document.fonts.ready() method is going to be replaced with docum ent.fonts.ready attribute in future releases. Please be prepared. For more help, check https://code.google.com/p/chromium/issues/detail?id=392077#c3 .";
821 821
822 case DOMImplementationHasFeatureReturnFalse:
823 return "'DOMImplementation.hasFeature()' returning false is deprecated. Please do not use it, as per DOM it should always return true (https://dom.spec. whatwg.org/#dom-domimplementation-hasfeature).";
824
822 // Features that aren't deprecated don't have a deprecation message. 825 // Features that aren't deprecated don't have a deprecation message.
823 default: 826 default:
824 return String(); 827 return String();
825 } 828 }
826 } 829 }
827 830
828 void UseCounter::count(CSSParserContext context, CSSPropertyID feature) 831 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)
829 { 832 {
830 ASSERT(feature >= firstCSSProperty); 833 ASSERT(feature >= firstCSSProperty);
831 ASSERT(feature <= lastCSSProperty); 834 ASSERT(feature <= lastCSSProperty);
(...skipping 28 matching lines...) Expand all
860 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 863 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
861 { 864 {
862 // FIXME: We may want to handle stylesheets that have multiple owners 865 // FIXME: We may want to handle stylesheets that have multiple owners
863 // http://crbug.com/242125 866 // http://crbug.com/242125
864 if (sheetContents && sheetContents->hasSingleOwnerNode()) 867 if (sheetContents && sheetContents->hasSingleOwnerNode())
865 return getFrom(sheetContents->singleOwnerDocument()); 868 return getFrom(sheetContents->singleOwnerDocument());
866 return 0; 869 return 0;
867 } 870 }
868 871
869 } // namespace blink 872 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/dom/DOMImplementation.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698