Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issue 693333002: Teach push script to commit with roll account. (Closed)

Created:
6 years, 1 month ago by Michael Achenbach
Modified:
6 years, 1 month ago
Reviewers:
tandrii(chromium)
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Teach push script to commit with roll account. BUG=410721 LOG=n TEST=script_test.py TBR=tandrii@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25046

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -10 lines) Patch
M tools/push-to-trunk/auto_push.py View 1 1 chunk +15 lines, -6 lines 0 comments Download
M tools/push-to-trunk/common_includes.py View 2 chunks +19 lines, -1 line 0 comments Download
M tools/push-to-trunk/git_recipes.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/push-to-trunk/push_to_trunk.py View 1 chunk +4 lines, -1 line 0 comments Download
M tools/push-to-trunk/test_scripts.py View 3 chunks +131 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/693333002/diff/1/tools/push-to-trunk/common_includes.py File tools/push-to-trunk/common_includes.py (right): https://codereview.chromium.org/693333002/diff/1/tools/push-to-trunk/common_includes.py#newcode432 tools/push-to-trunk/common_includes.py:432: def GitSvn(self, hsh, branch=""): Not so sure here. ...
6 years, 1 month ago (2014-11-01 21:49:26 UTC) #2
Michael Achenbach
Committed patchset #2 (id:20001) manually as 25046 (presubmit successful).
6 years, 1 month ago (2014-11-01 21:53:23 UTC) #3
tandrii(chromium)
6 years, 1 month ago (2014-11-03 16:49:51 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698