Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: tools/push-to-trunk/auto_push.py

Issue 693333002: Teach push script to commit with roll account. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/push-to-trunk/common_includes.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/push-to-trunk/auto_push.py
diff --git a/tools/push-to-trunk/auto_push.py b/tools/push-to-trunk/auto_push.py
index e53fe2fc91643612a63db05c01e3240e658af2d2..cec1489de4167a210f94c13e791a89f49bda0242 100755
--- a/tools/push-to-trunk/auto_push.py
+++ b/tools/push-to-trunk/auto_push.py
@@ -105,14 +105,23 @@ class PushToCandidates(Step):
def RunStep(self):
print "Pushing lkgr %s to candidates." % self["lkgr"]
+ args = [
+ "--author", self._options.author,
+ "--reviewer", self._options.reviewer,
+ "--revision", self["lkgr"],
+ "--force",
+ ]
+
+ if self._options.svn:
+ args.extend(["--svn", self._options.svn])
+ if self._options.svn_config:
+ args.extend(["--svn-config", self._options.svn_config])
+ if self._options.vc_interface:
+ args.extend(["--vc-interface", self._options.vc_interface])
+
# TODO(machenbach): Update the script before calling it.
if self._options.push:
- self._side_effect_handler.Call(
- push_to_trunk.PushToTrunk().Run,
- ["--author", self._options.author,
- "--reviewer", self._options.reviewer,
- "--revision", self["lkgr"],
- "--force"])
+ self._side_effect_handler.Call(push_to_trunk.PushToTrunk().Run, args)
class AutoPush(ScriptsBase):
« no previous file with comments | « no previous file | tools/push-to-trunk/common_includes.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698