Dont set SwapInterval with Surfaceless.

Dont set SwapInterval with Surfaceless.

EglSwapInterval doesn't take any effect when using a Surfacless
Context and will just return EGL_BAD_SURFACE in this case. This
patch adds checks to track if the current context is surfaceless
and ignores swap interval call in that case.

Tested by building Chromium with ChromesOS and
Ozone builds options and by launching chromium with the
following run time options:
chrome --no-sandbox --ozone-platform=gbm --ozone-use-surfaceless

After this change, I don't see any more EGL error as result of setting the SwapInterval
with surfaceless context during the launch time.
i.e. libEGL debug: EGL user error 0x300d (EGL_BAD_SURFACE) in eglSwapInterval

BUG=380861
Committed: https://crrev.com/bd709ad9b0e1f2d7124eb4d91ad9cde24245a7e6
Cr-Commit-Position: refs/heads/master@{#302506}

[kalyank, 2014-11-01 16:12:56]

kalyan.kondapally@intel.com changed reviewers:
+ piman@chromium.org

[piman, 2014-11-03 19:43:13]

https://codereview.chromium.org/693313002/diff/20001/ui/gl/gl_context_egl.cc
File ui/gl/gl_context_egl.cc (right):

https://codereview.chromium.org/693313002/diff/20001/ui/gl/gl_context_egl.cc#...
ui/gl/gl_context_egl.cc:184: if (is_surfaceless_context_)
Rather than stashing a bool, you can simply use
GLSurface::GetCurrent()->IsSurfaceLess()

[kalyank, 2014-11-03 20:04:54]

https://codereview.chromium.org/693313002/diff/20001/ui/gl/gl_context_egl.cc
File ui/gl/gl_context_egl.cc (right):

https://codereview.chromium.org/693313002/diff/20001/ui/gl/gl_context_egl.cc#...
ui/gl/gl_context_egl.cc:184: if (is_surfaceless_context_)
On 2014/11/03 19:43:13, piman (Very slow to review) wrote:
> Rather than stashing a bool, you can simply use
> GLSurface::GetCurrent()->IsSurfaceLess()

Didn't realize that, thanks. Will do that.

[kalyank, 2014-11-03 20:46:11]

@piman PTAL.

https://codereview.chromium.org/693313002/diff/20001/ui/gl/gl_context_egl.cc
File ui/gl/gl_context_egl.cc (right):

https://codereview.chromium.org/693313002/diff/20001/ui/gl/gl_context_egl.cc#...
ui/gl/gl_context_egl.cc:184: if (is_surfaceless_context_)
On 2014/11/03 19:43:13, piman (Very slow to review) wrote:
> Rather than stashing a bool, you can simply use
> GLSurface::GetCurrent()->IsSurfaceLess()

Done.

[piman, 2014-11-03 21:15:01]

lgtm

[kalyank, 2014-11-03 21:20:53]

kalyan.kondapally@intel.com changed reviewers:
+ dnicoara@chromium.org

[kalyank, 2014-11-03 21:21:36]

On 2014/11/03 21:15:01, piman (Very slow to review) wrote:
> lgtm

@dnicoara Can you PTAL to Ozone related changes.

[dnicoara, 2014-11-03 21:50:57]

lgtm

[kalyank, 2014-11-03 21:54:52]

The CQ bit was checked by kalyan.kondapally@intel.com

[commit-bot: I haz the power, 2014-11-03 21:55:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/693313002/40001

[commit-bot: I haz the power, 2014-11-03 22:43:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-03 22:45:13]

Patchset 3 (id:??) landed as
https://crrev.com/bd709ad9b0e1f2d7124eb4d91ad9cde24245a7e6
Cr-Commit-Position: refs/heads/master@{#302506}