Dont set SwapInterval with Surfaceless.

ui/gl/gl_context_egl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gl/gl_context_egl.h"
 
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "build/build_config.h"
@@ skipping 11 matching lines @@
 
 using ui::GetLastEGLErrorString;
 
 namespace gfx {
 
 GLContextEGL::GLContextEGL(GLShareGroup* share_group)
     : GLContextReal(share_group),
       context_(NULL),
       display_(NULL),
       config_(NULL),
-      unbind_fbo_on_makecurrent_(false) {
+      unbind_fbo_on_makecurrent_(false),
+      is_surfaceless_context_(false) {
 }
 
 bool GLContextEGL::Initialize(
     GLSurface* compatible_surface, GpuPreference gpu_preference) {
   DCHECK(compatible_surface);
   DCHECK(!context_);
 
   static const EGLint kContextAttributes[] = {
     EGL_CONTEXT_CLIENT_VERSION, 2,
     EGL_NONE
@@ skipping 24 matching lines @@
       config_,
       share_group() ? share_group()->GetHandle() : NULL,
       context_attributes);
 
   if (!context_) {
     LOG(ERROR) << "eglCreateContext failed with error "
                << GetLastEGLErrorString();
     return false;
   }
 
+  is_surfaceless_context_ = compatible_surface->IsSurfaceless();
+
   return true;
 }
 
 void GLContextEGL::Destroy() {
   if (context_) {
     if (!eglDestroyContext(display_, context_)) {
       LOG(ERROR) << "eglDestroyContext failed with error "
                  << GetLastEGLErrorString();
     }
 
@@ skipping 31 matching lines @@
   SetCurrent(surface);
   if (!InitializeDynamicBindings()) {
     return false;
   }
 
   if (!surface->OnMakeCurrent(this)) {
     LOG(ERROR) << "Could not make current.";
     return false;
   }
 
+  is_surfaceless_context_ = surface->IsSurfaceless();
   release_current.Cancel();
   return true;
 }
 
 void GLContextEGL::SetUnbindFboOnMakeCurrent() {
   unbind_fbo_on_makecurrent_ = true;
 }
 
 void GLContextEGL::ReleaseCurrent(GLSurface* surface) {
   if (!IsCurrent(surface))
@@ skipping 29 matching lines @@
 
   return true;
 }
 
 void* GLContextEGL::GetHandle() {
   return context_;
 }
 
 void GLContextEGL::SetSwapInterval(int interval) {
   DCHECK(IsCurrent(NULL));
+
+  // This is a surfaceless context. eglSwapInterval doesn't take any effect in
+  // this case and will just return EGL_BAD_SURFACE.
+  if (is_surfaceless_context_)

[piman, 2014/11/03 19:43:13]

Rather than stashing a bool, you can simply use
GLSurface::GetCurrent()->IsSurfaceLess()

[kalyank, 2014/11/03 20:04:53]

Didn't realize that, thanks. Will do that.

[kalyank, 2014/11/03 20:46:11]

Done.

+    return;
+
   if (!eglSwapInterval(display_, interval)) {
     LOG(ERROR) << "eglSwapInterval failed with error "
                << GetLastEGLErrorString();
   }
 }
 
 std::string GLContextEGL::GetExtensions() {
   const char* extensions = eglQueryString(display_,
                                           EGL_EXTENSIONS);
   if (!extensions)
@@ skipping 12 matching lines @@
 
 #if !defined(OS_ANDROID)
 bool GLContextEGL::GetTotalGpuMemory(size_t* bytes) {
   DCHECK(bytes);
   *bytes = 0;
   return false;
 }
 #endif
 
 }  // namespace gfx