Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 693283002: Avoid anchoring to pseudo elements when using logical ordering in a selection (Closed)

Created:
6 years, 1 month ago by rhogan
Modified:
6 years, 1 month ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

Avoid anchoring to pseudo elements when using logical ordering in a selection When we start the selection range in an element the selection is taken to include its :before or :after pseudoelement. So likewise when we modify the selection to an element on a line boundary that selection should include its :before/:after pseduoelements. BUG=342574 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184798

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css-generated-content/crash-selection-editing-removes-pseudo.html View 2 chunks +10 lines, -4 lines 0 comments Download
M LayoutTests/fast/css-generated-content/crash-selection-editing-removes-pseudo-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RootInlineBox.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
esprehn
lgtm, thanks for fixing this crash! https://codereview.chromium.org/693283002/diff/1/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/693283002/diff/1/LayoutTests/TestExpectations#newcode660 LayoutTests/TestExpectations:660: # ASSERT fails ...
6 years, 1 month ago (2014-11-03 18:46:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693283002/20001
6 years, 1 month ago (2014-11-03 19:23:47 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 20:24:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184798

Powered by Google App Engine
This is Rietveld 408576698