Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1275)

Unified Diff: Source/core/rendering/RootInlineBox.cpp

Issue 693283002: Avoid anchoring to pseudo elements when using logical ordering in a selection (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/css-generated-content/crash-selection-editing-removes-pseudo-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RootInlineBox.cpp
diff --git a/Source/core/rendering/RootInlineBox.cpp b/Source/core/rendering/RootInlineBox.cpp
index 2cd1c556ad9e490a9daaddd4006c01571532a62c..3683e5698ec1a4bf676a04fd53ed23a034de94da 100644
--- a/Source/core/rendering/RootInlineBox.cpp
+++ b/Source/core/rendering/RootInlineBox.cpp
@@ -834,9 +834,9 @@ Node* RootInlineBox::getLogicalStartBoxWithNode(InlineBox*& startBox) const
Vector<InlineBox*> leafBoxesInLogicalOrder;
collectLeafBoxesInLogicalOrder(leafBoxesInLogicalOrder);
for (size_t i = 0; i < leafBoxesInLogicalOrder.size(); ++i) {
- if (leafBoxesInLogicalOrder[i]->renderer().node()) {
+ if (leafBoxesInLogicalOrder[i]->renderer().nonPseudoNode()) {
startBox = leafBoxesInLogicalOrder[i];
- return startBox->renderer().node();
+ return startBox->renderer().nonPseudoNode();
}
}
startBox = 0;
@@ -848,9 +848,9 @@ Node* RootInlineBox::getLogicalEndBoxWithNode(InlineBox*& endBox) const
Vector<InlineBox*> leafBoxesInLogicalOrder;
collectLeafBoxesInLogicalOrder(leafBoxesInLogicalOrder);
for (size_t i = leafBoxesInLogicalOrder.size(); i > 0; --i) {
- if (leafBoxesInLogicalOrder[i - 1]->renderer().node()) {
+ if (leafBoxesInLogicalOrder[i - 1]->renderer().nonPseudoNode()) {
endBox = leafBoxesInLogicalOrder[i - 1];
- return endBox->renderer().node();
+ return endBox->renderer().nonPseudoNode();
}
}
endBox = 0;
« no previous file with comments | « LayoutTests/fast/css-generated-content/crash-selection-editing-removes-pseudo-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698