Issue 693223002: Revert of Temporary fix to remove drawrect call from GpuGL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 693223002: Revert of Temporary fix to remove drawrect call from GpuGL (Closed)

Created:
6 years, 1 month ago by joshualitt

Modified:
6 years, 1 month ago

Reviewers:
bsalomon, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@cleanupcontext

Project:
skia

Visibility:
Public.

Revert of Temporary fix to remove drawrect call from GpuGL (patchset #6 id:90005 of https://codereview.chromium.org/694933002/) Reason for revert: patch breaks angle bots and K1 Original issue's description: > Temporary fix to remove drawrect call from GpuGL > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/d4a5c2028117c100ccf44263c0118a0b4745f627 TBR=bsalomon@google.com,joshualitt@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/a393127de5153987f9e1f3e40f8ef8e63a3927f5

Created: 6 years, 1 month ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -14 lines)			Patch
M	src/gpu/GrDrawTarget.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	5 chunks	+14 lines, -9 lines	0 comments	Download

Total messages: 3 (0 generated)

joshualitt

Created Revert of Temporary fix to remove drawrect call from GpuGL

6 years, 1 month ago (2014-10-31 23:32:04 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693223002/1

6 years, 1 month ago (2014-10-31 23:32:12 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-10-31 23:32:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as a393127de5153987f9e1f3e40f8ef8e63a3927f5