Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 693153003: Revert of Registration of DevTools bridge in GCD. (Closed)

Created:
6 years, 1 month ago by Mike Lerman
Modified:
6 years, 1 month ago
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman, Roman
Base URL:
https://chromium.googlesource.com/chromium/src.git@gcm-signaling
Project:
chromium
Visibility:
Public.

Description

Revert of Registration of DevTools bridge in GCD. (patchset #4 id:80001 of https://codereview.chromium.org/677843006/) Reason for revert: Only CL that landed before http://build.chromium.org/p/chromium.mac/waterfall?builder=Mac%20Builder broke. Going to revert this CL to try and get the builder working again. Original issue's description: > Registration of DevTools bridge in GCD. > > Code for registering and unregistering instance of DevTools bridge in GCD. > GCDRegistrationFragment is able to perform registration including: > 1. Asking user for desired account to register. > 2. Requesting OAuth permissions for GCD (may show confirmation activity to the user). > 3. Registration in Cloud Messages if needed. > > It also shows toasts with registration/unregistration results. > > GCDRegistrationFragment is absstract and has no views. Testing implementation > shows button "Registed in GCD/Unregister (registered for ...)". Registration is not > persistent yet. > > BUG=383418 > TEST=New button in main activity of DevToolsBridgeTest.apk: register/unregister. > > Committed: https://crrev.com/a2da02bd99d78de549b617510551ec5e1f7073d9 > Cr-Commit-Position: refs/heads/master@{#302251} TBR=mnaganov@chromium.org,serya@chromium.org NOTREECHECKS=true NOTRY=true BUG=383418 Committed: https://crrev.com/5873e1464c3c2d8ffb1a7364eeb2d689ab254c34 Cr-Commit-Position: refs/heads/master@{#302254}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1435 lines) Patch
M components/devtools_bridge.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/apiary/ApiaryClientFactory.java View 1 chunk +0 lines, -56 lines 0 comments Download
D components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/apiary/BlockingGCMRegistrar.java View 1 chunk +0 lines, -84 lines 0 comments Download
D components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/apiary/GCDClient.java View 1 chunk +0 lines, -161 lines 0 comments Download
D components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/apiary/JsonResponseHandler.java View 1 chunk +0 lines, -70 lines 0 comments Download
D components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/apiary/OAuthClient.java View 1 chunk +0 lines, -102 lines 0 comments Download
D components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/apiary/OAuthResult.java View 1 chunk +0 lines, -28 lines 0 comments Download
M components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/commands/CommandDefinition.java View 1 chunk +3 lines, -3 lines 0 comments Download
M components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/commands/Commands.java View 3 chunks +4 lines, -4 lines 0 comments Download
D components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/gcd/InstanceCredential.java View 1 chunk +0 lines, -28 lines 0 comments Download
D components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/gcd/InstanceDescription.java View 1 chunk +0 lines, -55 lines 0 comments Download
D components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/gcd/MessageReader.java View 1 chunk +0 lines, -84 lines 0 comments Download
D components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/gcd/MessageWriter.java View 1 chunk +0 lines, -109 lines 0 comments Download
D components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/ui/GCDRegistrationFragment.java View 1 chunk +0 lines, -283 lines 0 comments Download
M components/devtools_bridge/android/javatests/AndroidManifest.xml View 1 chunk +0 lines, -2 lines 0 comments Download
D components/devtools_bridge/android/javatests/src/org/chromium/components/devtools_bridge/apiary/JsonResponseHandlerTest.java View 1 chunk +0 lines, -138 lines 0 comments Download
D components/devtools_bridge/android/javatests/src/org/chromium/components/devtools_bridge/apiary/OAuthClientTest.java View 1 chunk +0 lines, -39 lines 0 comments Download
D components/devtools_bridge/android/javatests/src/org/chromium/components/devtools_bridge/gcd/MessageReaderTest.java View 1 chunk +0 lines, -55 lines 0 comments Download
M components/devtools_bridge/android/javatests/src/org/chromium/components/devtools_bridge/tests/DebugActivity.java View 4 chunks +7 lines, -68 lines 0 comments Download
D components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/apiary/TestApiaryClientFactory.java View 1 chunk +0 lines, -33 lines 0 comments Download
D components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/util/TestSource.java View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike Lerman
Created Revert of Registration of DevTools bridge in GCD.
6 years, 1 month ago (2014-10-31 13:02:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693153003/1
6 years, 1 month ago (2014-10-31 13:03:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 13:04:16 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 13:05:24 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5873e1464c3c2d8ffb1a7364eeb2d689ab254c34
Cr-Commit-Position: refs/heads/master@{#302254}

Powered by Google App Engine
This is Rietveld 408576698