Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/gcd/MessageWriter.java

Issue 693153003: Revert of Registration of DevTools bridge in GCD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gcm-signaling
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/gcd/MessageWriter.java
diff --git a/components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/gcd/MessageWriter.java b/components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/gcd/MessageWriter.java
deleted file mode 100644
index ee8ead6976233cb1f4ba1a006a2889620951740c..0000000000000000000000000000000000000000
--- a/components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/gcd/MessageWriter.java
+++ /dev/null
@@ -1,109 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package org.chromium.components.devtools_bridge.gcd;
-
-import android.util.JsonWriter;
-
-import org.chromium.components.devtools_bridge.commands.Command;
-import org.chromium.components.devtools_bridge.commands.ParamDefinition;
-
-import java.io.IOException;
-import java.io.StringWriter;
-
-/**
- * Helper class for constructing GCD JSON messages (HTTP requests) used in the DevTools bridge.
- */
-public final class MessageWriter {
- private final StringWriter mStringWriter;
- private final JsonWriter mWriter;
- boolean mClosed = false;
-
- public MessageWriter() {
- mStringWriter = new StringWriter();
- mWriter = new JsonWriter(mStringWriter);
- }
-
- public MessageWriter close() throws IOException {
- assert !mClosed;
- mWriter.close();
- mClosed = true;
- return this;
- }
-
- @Override
- public String toString() {
- assert mClosed;
- return mStringWriter.toString();
- }
-
- /**
- * Write body of registrationTicket PATCH request.
- */
- public MessageWriter writeTicketPatch(InstanceDescription description) throws IOException {
- mWriter.beginObject();
- mWriter.name("deviceDraft");
- writeDeviceDraft(description);
- mWriter.name("oauthClientId").value(description.oAuthClientId);
- mWriter.endObject();
- return this;
- }
-
- private void writeDeviceDraft(InstanceDescription description) throws IOException {
- mWriter.beginObject();
- mWriter.name("deviceKind").value("vendor");
- mWriter.name("displayName").value(description.displayName);
- mWriter.name("systemName").value("Chrome DevTools Bridge");
- mWriter.name("channel");
- writeChannelDefinition(description);
- mWriter.name("commandDefs");
- writeCommandsDefinition();
- mWriter.endObject();
- }
-
- private void writeChannelDefinition(InstanceDescription description) throws IOException {
- mWriter.beginObject();
- mWriter.name("supportedType").value("gcm");
- mWriter.name("gcmRegistrationId").value(description.gcmChannelId);
- mWriter.endObject();
- }
-
- private void writeCommandsDefinition() throws IOException {
- mWriter.beginObject();
- mWriter.name("base");
- writeCommandsDefinitionBase();
- mWriter.endObject();
- }
-
- private void writeCommandsDefinitionBase() throws IOException {
- mWriter.beginObject();
- for (Command.Type type : Command.Type.values()) {
- mWriter.name(type.definition.shortName());
- beginParameters();
- for (ParamDefinition<?> param : type.definition.inParams()) {
- writeParameter(param.name(), param.type());
- }
- endParameters();
- }
- mWriter.endObject();
- }
-
- private void beginParameters() throws IOException {
- mWriter.beginObject();
- mWriter.name("parameters");
- mWriter.beginObject();
- }
-
- private void endParameters() throws IOException {
- mWriter.endObject();
- mWriter.endObject();
- }
-
- private void writeParameter(String name, String type) throws IOException {
- mWriter.name(name);
- mWriter.beginObject();
- mWriter.name("type").value(type);
- mWriter.endObject();
- }
-}

Powered by Google App Engine
This is Rietveld 408576698