Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: chrome/browser/resources/security_warnings/interstitial_v2.js

Issue 693093003: Clock interstitial: refine iOS text and hide 'Advanced' button. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address style nits. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/security_warnings/interstitial_v2.js
diff --git a/chrome/browser/resources/security_warnings/interstitial_v2.js b/chrome/browser/resources/security_warnings/interstitial_v2.js
index 56ae8573a3c3f7c05b6b0aba4fd22975ff227f8a..e3ac1b065eed9294686c452c6d7c7195063588e7 100644
--- a/chrome/browser/resources/security_warnings/interstitial_v2.js
+++ b/chrome/browser/resources/security_warnings/interstitial_v2.js
@@ -67,6 +67,8 @@ function setupEvents() {
var overridable = loadTimeData.getBoolean('overridable');
var ssl = loadTimeData.getString('type') === 'SSL';
var badClock = ssl && loadTimeData.getBoolean('bad_clock');
+ var hidePrimaryButton = badClock && loadTimeData.getBoolean(
+ 'hide_primary_button');
if (ssl) {
$('body').classList.add(badClock ? 'bad-clock' : 'ssl');
@@ -76,16 +78,20 @@ function setupEvents() {
$('body').classList.add('safe-browsing');
}
- $('primary-button').addEventListener('click', function() {
- if (!ssl)
- sendCommand(SB_CMD_TAKE_ME_BACK);
- else if (badClock)
- sendCommand(SSL_CMD_CLOCK);
- else if (overridable)
- sendCommand(SSL_CMD_DONT_PROCEED);
- else
- sendCommand(SSL_CMD_RELOAD);
- });
+ if (hidePrimaryButton) {
+ $('primary-button').classList.add('hidden');
+ } else {
+ $('primary-button').addEventListener('click', function() {
+ if (!ssl)
+ sendCommand(SB_CMD_TAKE_ME_BACK);
+ else if (badClock)
+ sendCommand(SSL_CMD_CLOCK);
+ else if (overridable)
+ sendCommand(SSL_CMD_DONT_PROCEED);
+ else
+ sendCommand(SSL_CMD_RELOAD);
+ });
+ }
if (overridable) {
$('proceed-link').addEventListener('click', function(event) {
@@ -110,18 +116,14 @@ function setupEvents() {
}
$('details-button').addEventListener('click', function(event) {
- if (badClock) {
- sendCommand(SSL_CMD_RELOAD);
- } else {
- var hiddenDetails = $('details').classList.toggle('hidden');
- $('details-button').innerText = hiddenDetails ?
- loadTimeData.getString('openDetails') :
- loadTimeData.getString('closeDetails');
- if (!expandedDetails) {
- // Record a histogram entry only the first time that details is opened.
- sendCommand(ssl ? SSL_CMD_MORE : SB_CMD_EXPANDED_SEE_MORE);
- expandedDetails = true;
- }
+ var hiddenDetails = $('details').classList.toggle('hidden');
+ $('details-button').innerText = hiddenDetails ?
+ loadTimeData.getString('openDetails') :
+ loadTimeData.getString('closeDetails');
+ if (!expandedDetails) {
+ // Record a histogram entry only the first time that details is opened.
+ sendCommand(ssl ? SSL_CMD_MORE : SB_CMD_EXPANDED_SEE_MORE);
+ expandedDetails = true;
}
});

Powered by Google App Engine
This is Rietveld 408576698