Clock interstitial: refine iOS text and hide 'Advanced' button.

Clock interstitial: refine iOS text and hide 'Advanced' button.

On iOS, we can't link directly to the date and time settings, so we hide the primary button and add an extra description to the main paragraph instructing them how to do so.
For all platforms, we completely hide the 'Advanced' button on the SSL clock interstitial. (It was replaced with 'Reload' in previous iterations.)

Hide Reload button for all clock errors.

BUG=414843
Committed: https://crrev.com/5842d631f77b02ed36c39037eb942d935e082406
Cr-Commit-Position: refs/heads/master@{#302664}

[lgarron, 2014-10-31 21:11:37]

Patchset #1 (id:1) has been deleted

[lgarron, 2014-10-31 23:08:40]

lgarron@chromium.org changed reviewers:
+ bauerb@chromium.org, felt@chromium.org

[lgarron, 2014-10-31 23:08:41]

felt@: Would you please review everything?

bauerb@: Would you please review interstitial_v2.js?

[felt, 2014-11-01 21:39:12]

https://codereview.chromium.org/693093003/diff/40001/chrome/app/generated_res...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/693093003/diff/40001/chrome/app/generated_res...
chrome/app/generated_resources.grd:9695: +          <p>A private
connection to <ph name="DOMAIN">$1<ex>paypal.com</ex></ph> can't be established
because your computer's date and time (<ph name="DATE_AND_TIME">$2<ex>Monday,
January 1, 1970 2:44:30 PM</ex></ph>) are incorrect.&lt;/p&gt;
Should that be "your device's date and time" (device instead of computer)? Also
I am thinking it should be "device" for Android too.

https://codereview.chromium.org/693093003/diff/40001/chrome/browser/resources...
File chrome/browser/resources/security_warnings/interstitial_v2.js (right):

https://codereview.chromium.org/693093003/diff/40001/chrome/browser/resources...
chrome/browser/resources/security_warnings/interstitial_v2.js:84: else {
} else {

https://codereview.chromium.org/693093003/diff/40001/chrome/browser/ssl/ssl_b...
File chrome/browser/ssl/ssl_blocking_page.cc (right):

https://codereview.chromium.org/693093003/diff/40001/chrome/browser/ssl/ssl_b...
chrome/browser/ssl/ssl_blocking_page.cc:468:
load_time_data.SetString("openDetails", std::string());
Does this work well? Do you end up with a single space or a small area you can
hover over to click on, or does it just become completely invisible?

[Bernhard Bauer, 2014-11-03 12:18:09]

https://codereview.chromium.org/693093003/diff/40001/chrome/browser/resources...
File chrome/browser/resources/security_warnings/interstitial_v2.js (right):

https://codereview.chromium.org/693093003/diff/40001/chrome/browser/resources...
chrome/browser/resources/security_warnings/interstitial_v2.js:71:
'hide_primary_button');
Nit: just indent this four spaces.

[lgarron, 2014-11-04 02:13:50]

https://codereview.chromium.org/693093003/diff/40001/chrome/app/generated_res...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/693093003/diff/40001/chrome/app/generated_res...
chrome/app/generated_resources.grd:9695: +          <p>A private
connection to <ph name="DOMAIN">$1<ex>paypal.com</ex></ph> can't be established
because your computer's date and time (<ph name="DATE_AND_TIME">$2<ex>Monday,
January 1, 1970 2:44:30 PM</ex></ph>) are incorrect.&lt;/p&gt;
On 2014/11/01 21:39:11, felt wrote:
> Should that be "your device's date and time" (device instead of computer)?
Also
> I am thinking it should be "device" for Android too.

Acknowledged.

https://codereview.chromium.org/693093003/diff/40001/chrome/browser/resources...
File chrome/browser/resources/security_warnings/interstitial_v2.js (right):

https://codereview.chromium.org/693093003/diff/40001/chrome/browser/resources...
chrome/browser/resources/security_warnings/interstitial_v2.js:71:
'hide_primary_button');
On 2014/11/03 12:18:08, Bernhard Bauer wrote:
> Nit: just indent this four spaces.

Acknowledged.

https://codereview.chromium.org/693093003/diff/40001/chrome/browser/resources...
chrome/browser/resources/security_warnings/interstitial_v2.js:84: else {
On 2014/11/01 21:39:11, felt wrote:
> } else {

Acknowledged.

https://codereview.chromium.org/693093003/diff/40001/chrome/browser/ssl/ssl_b...
File chrome/browser/ssl/ssl_blocking_page.cc (right):

https://codereview.chromium.org/693093003/diff/40001/chrome/browser/ssl/ssl_b...
chrome/browser/ssl/ssl_blocking_page.cc:468:
load_time_data.SetString("openDetails", std::string());
On 2014/11/01 21:39:11, felt wrote:
> Does this work well? Do you end up with a single space or a small area you can
> hover over to click on, or does it just become completely invisible?

You end up with an <a> element that has no dimensions. Nothing is visible or
clickable (unless someone changes the CSS in an unnatural way).

I'm happy to "actually" hide the button, but I wanted to limit the number of
special code paths until the interstitial types are refactored.

[felt, 2014-11-04 02:42:53]

lgtm

https://codereview.chromium.org/693093003/diff/60001/chrome/browser/ssl/ssl_b...
File chrome/browser/ssl/ssl_blocking_page.cc (right):

https://codereview.chromium.org/693093003/diff/60001/chrome/browser/ssl/ssl_b...
chrome/browser/ssl/ssl_blocking_page.cc:435: #if defined(OS_IOS)
this is gnarly, but I don't know a better way to do it :( but let my sadness be
placed on the record...

[Bernhard Bauer, 2014-11-04 12:08:24]

lgtm

[lgarron, 2014-11-04 19:43:56]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2014-11-04 19:46:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/693093003/60001

[commit-bot: I haz the power, 2014-11-04 21:03:33]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2014-11-04 21:05:29]

Patchset 3 (id:??) landed as
https://crrev.com/5842d631f77b02ed36c39037eb942d935e082406
Cr-Commit-Position: refs/heads/master@{#302664}