Named getter of HTMLAllCollection etc should be nullable

Named getter of HTMLAllCollection etc should be nullable

According to the spec[1,2,3], named getter of HTMLAllCollection, HTMLFormControlsCollection and HTMLOptionsCollection should be nullable.

This CL also adds layout tests for nullable arguments.

[1] https://html.spec.whatwg.org/multipage/infrastructure.html#the-htmlallcollection-interface
[2] https://html.spec.whatwg.org/multipage/infrastructure.html#the-htmlformcontrolscollection-interface
[3] https://html.spec.whatwg.org/multipage/infrastructure.html#htmlallcollection

BUG=430337
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185108

[bashi, 2014-11-11 01:39:26]

bashi@chromium.org changed reviewers:
+ haraken@chromium.org

[bashi, 2014-11-11 01:39:27]

PTAL?

[haraken, 2014-11-11 02:15:59]

Does this change web-exposed behavior? What's the behavior of other browsers?

[bashi, 2014-11-11 02:40:15]

On 2014/11/11 02:15:59, haraken wrote:
> Does this change web-exposed behavior? What's the behavior of other browsers?

No. This CL doesn't change web-exposed behavior. Named getters don't set return
value when impl classes return null, resulting undefined. For example,

document.all['no-such-element'] => undefined

I checked that Firefox and Safari also return undefined.

It seems that we don't have such test cases. Added.

[haraken, 2014-11-11 03:19:21]

LGTM

[bashi, 2014-11-11 03:20:55]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2014-11-11 03:21:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/692993003/40001

[commit-bot: I haz the power, 2014-11-11 04:23:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-11 04:23:02]

Failed to apply patch for Source/core/testing/UnionTypesTest.idl:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/testing/UnionTypesTest.idl
  Hunk #1 FAILED at 12.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/testing/UnionTypesTest.idl.rej

Patch:       Source/core/testing/UnionTypesTest.idl
Index: Source/core/testing/UnionTypesTest.idl
diff --git a/Source/core/testing/UnionTypesTest.idl
b/Source/core/testing/UnionTypesTest.idl
index
efc8a1801ea0667c577082a3a8669366c03c1be1..e3ce87a843f863abbfc536ec7418ebe30bd353de
100644
--- a/Source/core/testing/UnionTypesTest.idl
+++ b/Source/core/testing/UnionTypesTest.idl
@@ -12,4 +12,7 @@
     [ImplementedAs=doubleOrStringArg] DOMString
doubleOrStringDefaultDoubleArg(optional (double or DOMString) arg = 3.14);
     [ImplementedAs=doubleOrStringArg] DOMString
doubleOrStringDefaultStringArg(optional (double or DOMString) arg = "foo");
     [ImplementedAs=doubleOrStringArg] DOMString
doubleOrStringDefaultNullArg(optional (double or DOMString)? arg = null);
+
+    DOMString nodeListOrElementArg((NodeList or Element) arg);
+    DOMString nodeListOrElementOrNullArg((NodeList or Element)? arg);
 };

[commit-bot: I haz the power, 2014-11-11 04:23:09]

The CQ bit was unchecked by commit-bot@chromium.org

[bashi, 2014-11-11 04:55:43]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2014-11-11 04:55:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/692993003/60001

[commit-bot: I haz the power, 2014-11-11 06:50:56]

Committed patchset #4 (id:60001) as 185108