Source/core/html/HTMLOptionsCollection.idl - Issue 692993003: Named getter of HTMLAllCollection etc should be nullable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLOptionsCollection.idl

Issue 692993003: Named getter of HTMLAllCollection etc should be nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@union-nullable

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLOptionsCollection.idl

diff --git a/Source/core/html/HTMLOptionsCollection.idl b/Source/core/html/HTMLOptionsCollection.idl

index f451185fc6415263b88fabd31684e73173d62ce9..1809be9f11724aaabbdd600b935fddbea10f05b2 100644

--- a/Source/core/html/HTMLOptionsCollection.idl

+++ b/Source/core/html/HTMLOptionsCollection.idl

@@ -29,7 +29,7 @@

[RaisesException, TypeChecking=Interface] setter HTMLOptionElement (unsigned long index, HTMLOptionElement? value);

// FIXME: The spec and firefox return an Element (the first matching Element).

- [ImplementedAs=namedGetter] getter (NodeList or Element) namedItem(DOMString name);

+ [ImplementedAs=namedGetter] getter (NodeList or Element)? namedItem(DOMString name);

[Custom, RaisesException] void add([Default=Undefined] optional HTMLOptionElement option, optional unsigned long index);

void remove(unsigned long index);

« no previous file with comments | « Source/core/html/HTMLFormControlsCollection.idl ('k') | Source/core/testing/UnionTypesTest.h » ('j') | no next file with comments »