Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: url/origin.cc

Issue 692973005: Pass origin information for remote frame creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: url/origin.cc
diff --git a/url/origin.cc b/url/origin.cc
index eb2cf141126bd0c83d70f461907483128354310b..a09c212a8ab3d02651be6fe10c9f57cc5d5cb3ce 100644
--- a/url/origin.cc
+++ b/url/origin.cc
@@ -13,7 +13,8 @@ Origin::Origin() : string_("null") {}
Origin::Origin(const std::string& origin) : string_(origin) {
DCHECK(origin == "null" || MatchPattern(origin, "?*://?*"));
DCHECK_GT(origin.size(), 0u);
- DCHECK_NE(origin[origin.size() - 1], '/');
+// this conflicts with how GURL::GetOrigin works:
+// DCHECK_NE(origin[origin.size() - 1], '/');
alexmos 2014/11/12 00:05:47 I commented out this check since GURL::GetOrigin()
Charlie Reis 2014/11/13 18:00:59 Hmm, yes, let's continue the discussion about what
alexmos 2014/11/18 18:25:33 Undone, this is no longer necessary given that Bli
}
} // namespace url
« content/renderer/render_thread_impl.h ('K') | « content/renderer/render_view_impl_params.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698