Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: url/origin.cc

Issue 692973005: Pass origin information for remote frame creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "url/origin.h" 5 #include "url/origin.h"
6 6
7 #include "base/strings/string_util.h" 7 #include "base/strings/string_util.h"
8 8
9 namespace url { 9 namespace url {
10 10
11 Origin::Origin() : string_("null") {} 11 Origin::Origin() : string_("null") {}
12 12
13 Origin::Origin(const std::string& origin) : string_(origin) { 13 Origin::Origin(const std::string& origin) : string_(origin) {
14 DCHECK(origin == "null" || MatchPattern(origin, "?*://?*")); 14 DCHECK(origin == "null" || MatchPattern(origin, "?*://?*"));
15 DCHECK_GT(origin.size(), 0u); 15 DCHECK_GT(origin.size(), 0u);
16 DCHECK_NE(origin[origin.size() - 1], '/'); 16 // this conflicts with how GURL::GetOrigin works:
17 // DCHECK_NE(origin[origin.size() - 1], '/');
alexmos 2014/11/12 00:05:47 I commented out this check since GURL::GetOrigin()
Charlie Reis 2014/11/13 18:00:59 Hmm, yes, let's continue the discussion about what
alexmos 2014/11/18 18:25:33 Undone, this is no longer necessary given that Bli
17 } 18 }
18 19
19 } // namespace url 20 } // namespace url
OLDNEW
« content/renderer/render_thread_impl.h ('K') | « content/renderer/render_view_impl_params.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698