Hold the Pepper proxy lock for all Pepper GL calls.

ppapi/proxy/plugin_dispatcher.h

Index: ppapi/proxy/plugin_dispatcher.h
diff --git a/ppapi/proxy/plugin_dispatcher.h b/ppapi/proxy/plugin_dispatcher.h
index f8e22f6ebdedb69ce9c8eaaeb77199aa80a5e071..bd8ea329293166cc6fae7bb8a2e8644337cdeed8 100644
--- a/ppapi/proxy/plugin_dispatcher.h
+++ b/ppapi/proxy/plugin_dispatcher.h
@@ -142,6 +142,7 @@ class PPAPI_PROXY_EXPORT PluginDispatcher
   // Dispatcher overrides.
   virtual bool IsPlugin() const;
   virtual bool Send(IPC::Message* msg);

[dmichael (off chromium), 2014/10/30 21:20:56]

Wait, why are these marked virtual? I would expect "override".

[Peng, 2014/10/31 13:50:56]

Done.

+  virtual bool SendAndStayLocked(IPC::Message* msg);

[dmichael (off chromium), 2014/10/30 21:20:56]

And this one is not an override and should not be virtual.

Also, please add a comment indicating that while Send will release the proxy
lock on outgoing synchronous messages, SendAndStayLocked continues to hold the
lock unconditionally.

[Peng, 2014/10/31 13:50:56]

Actually this one is a virtual function, because the CommandProxy hold a
ProxyChannel instead of this class.

Comment added. Done

 
   // IPC::Listener implementation.
   virtual bool OnMessageReceived(const IPC::Message& msg);