Hold the Pepper proxy lock for all Pepper GL calls.

ppapi/proxy/plugin_dispatcher.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PPAPI_PROXY_PLUGIN_DISPATCHER_H_
 #define PPAPI_PROXY_PLUGIN_DISPATCHER_H_
 
 #include <set>
 #include <string>
 
@@ skipping 123 matching lines @@
   // You must call this function before anything else. Returns true on success.
   // The delegate pointer must outlive this class, ownership is not
   // transferred.
   bool InitPluginWithChannel(PluginDelegate* delegate,
                              base::ProcessId peer_pid,
                              const IPC::ChannelHandle& channel_handle,
                              bool is_client);
 
   // Dispatcher overrides.
   virtual bool IsPlugin() const;
   virtual bool Send(IPC::Message* msg);

[dmichael (off chromium), 2014/10/30 21:20:56]

Wait, why are these marked virtual? I would expect "override".

[Peng, 2014/10/31 13:50:56]

Done.

+  virtual bool SendAndStayLocked(IPC::Message* msg);

[dmichael (off chromium), 2014/10/30 21:20:56]

And this one is not an override and should not be virtual.

Also, please add a comment indicating that while Send will release the proxy
lock on outgoing synchronous messages, SendAndStayLocked continues to hold the
lock unconditionally.

[Peng, 2014/10/31 13:50:56]

Actually this one is a virtual function, because the CommandProxy hold a
ProxyChannel instead of this class.

Comment added. Done

 
   // IPC::Listener implementation.
   virtual bool OnMessageReceived(const IPC::Message& msg);
   virtual void OnChannelError();
 
   // Keeps track of which dispatcher to use for each instance, active instances
   // and tracks associated data like the current size.
   void DidCreateInstance(PP_Instance instance);
   void DidDestroyInstance(PP_Instance instance);
 
@@ skipping 51 matching lines @@
   // A filter for sending messages from threads other than the main thread.
   scoped_refptr<IPC::SyncMessageFilter> sync_filter_;
 
   DISALLOW_COPY_AND_ASSIGN(PluginDispatcher);
 };
 
 }  // namespace proxy
 }  // namespace ppapi
 
 #endif  // PPAPI_PROXY_PLUGIN_DISPATCHER_H_