Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 692643007: [TextBlob] Plumb a Font param for setupPaint(). (Closed)

Created:
6 years, 1 month ago by f(malita)
Modified:
6 years, 1 month ago
CC:
blink-reviews, krit, Rik, jbroman, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Project:
blink
Visibility:
Public.

Description

[TextBlob] Plumb a Font param for setupPaint(). Similarly to the non-blob code path, we should pass a Font arg to setupPaint() for Mac hinting heuristics. (See https://codereview.chromium.org/692643006) BUG=421412 R=eae@chromium.org,jbroman@chromium.org,bungeman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185082

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/platform/fonts/Font.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
f(malita)
6 years, 1 month ago (2014-11-11 00:29:06 UTC) #1
eae
LGTM
6 years, 1 month ago (2014-11-11 00:30:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692643007/1
6 years, 1 month ago (2014-11-11 00:31:27 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 00:49:30 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 185082

Powered by Google App Engine
This is Rietveld 408576698