Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 692643006: Restore webkit-font-smoothing. (Closed)

Created:
6 years, 1 month ago by bungeman-chromium
Modified:
6 years, 1 month ago
CC:
blink-reviews, Rik, danakj, krit, f(malita), jbroman, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Restore webkit-font-smoothing. With https://codereview.chromium.org/175253002 (Blink r182920) webkit-font-smoothing was broken on Mac. This restores the previous behavior. BUG=chromium:421412 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185065

Patch Set 1 #

Patch Set 2 : const *all* the things. #

Patch Set 3 : Add expectations. #

Patch Set 4 : Mark reftest as image failure. #

Patch Set 5 : One more (only fails debug?) #

Patch Set 6 : Update flaky test expectations. #

Patch Set 7 : Actually suppress flaky tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -86 lines) Patch
M LayoutTests/FlakyTests View 1 2 3 4 5 6 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/StaleTestExpectations View 1 2 1 chunk +67 lines, -0 lines 0 comments Download
M LayoutTests/TestExpectations View 1 2 3 4 5 2 chunks +233 lines, -65 lines 0 comments Download
M Source/platform/fonts/Font.h View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/platform/fonts/Font.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/platform/fonts/FontPlatformData.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/platform/fonts/linux/FontPlatformDataLinux.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/platform/fonts/mac/FontPlatformDataMac.mm View 3 chunks +8 lines, -3 lines 0 comments Download
M Source/platform/fonts/win/FontPlatformDataWin.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
bungeman-chromium
This restores the behavior we had before, where the information was only available at raster ...
6 years, 1 month ago (2014-11-07 15:57:04 UTC) #2
esprehn
Can you add a test?
6 years, 1 month ago (2014-11-07 18:05:54 UTC) #3
bungeman-chromium
On 2014/11/07 18:05:54, esprehn wrote: > Can you add a test? Not sure what you ...
6 years, 1 month ago (2014-11-07 18:19:01 UTC) #4
esprehn
On 2014/11/07 at 18:19:01, bungeman wrote: > On 2014/11/07 18:05:54, esprehn wrote: > > Can ...
6 years, 1 month ago (2014-11-07 18:22:18 UTC) #5
bungeman-chromium
On 2014/11/07 18:22:18, esprehn wrote: > On 2014/11/07 at 18:19:01, bungeman wrote: > > On ...
6 years, 1 month ago (2014-11-07 18:53:41 UTC) #6
bungeman-chromium
It appears that I have managed to make the bots happy for the time being. ...
6 years, 1 month ago (2014-11-10 20:24:40 UTC) #7
eae
LGTM
6 years, 1 month ago (2014-11-10 20:28:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692643006/120001
6 years, 1 month ago (2014-11-10 20:31:37 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 21:44:15 UTC) #11
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as 185065

Powered by Google App Engine
This is Rietveld 408576698