Issue 69243003: Revert 234233 "Add mojo_idl_generator.gypi"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 69243003: Revert 234233 "Add mojo_idl_generator.gypi" (Closed)

Created:
7 years, 1 month ago by Nico

Modified:
7 years, 1 month ago

Reviewers:
DaveMoore

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 234233 "Add mojo_idl_generator.gypi" Broke all windows try jobs. Example: http://build.chromium.org/p/tryserver.chromium/builders/win/builds/124746 FAILED: E:\b\depot_tools\python_bin\python.exe gyp-win-tool action-wrapper environment.x86 mojom_test_target_Generate_C___source_files_from_mojom_files_ff8ddd79354be39f4d49ff68f7050968.f7de501d36c9a2def832b8cb44ee34af.rsp Traceback (most recent call last): File "../mojo/public/bindings/mojom_bindings_generator.py", line 12, in <module> from parser import mojo_parser ImportError: cannot import name mojo_parser ninja: build stopped: subcommand failed. > Add mojo_idl_generator.gypi > NOT FOR REVIEW > BUG= > R=darin@chromium.org > > Review URL: https://codereview.chromium.org/53173008 TBR=davemoore@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234277

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+30 lines, -566 lines)			Patch
trunk/src/mojo/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
trunk/src/mojo/mojo.gyp	View	2 chunks	+4 lines, -19 lines	0 comments	Download
trunk/src/mojo/public/bindings/mojo_idl.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
trunk/src/mojo/public/bindings/mojom_bindings_generator.gypi	View	1 chunk	+0 lines, -46 lines	0 comments	Download
trunk/src/mojo/public/bindings/mojom_bindings_generator.py	View	1 chunk	+0 lines, -46 lines	0 comments	Download
trunk/src/mojo/public/bindings/sample/generated/sample_service.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
trunk/src/mojo/public/bindings/sample/generated/sample_service.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
trunk/src/mojo/public/bindings/sample/generated/sample_service_internal.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
trunk/src/mojo/public/bindings/sample/mojom/sample_service.h	View	1 chunk	+0 lines, -132 lines	0 comments	Download
trunk/src/mojo/public/bindings/sample/mojom/sample_service.cc	View	1 chunk	+0 lines, -253 lines	0 comments	Download
trunk/src/mojo/public/bindings/sample/mojom/sample_service_internal.h	View	1 chunk	+0 lines, -41 lines	0 comments	Download
trunk/src/mojo/public/bindings/sample/sample_service.idl	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
trunk/src/mojo/public/bindings/sample/sample_service.mojom	View	1 chunk	+30 lines, -32 lines	0 comments	Download
trunk/src/mojo/public/bindings/sample/sample_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r234277.

Expand Messages | Collapse Messages