Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 53173008: Add mojom_bindings_generator.gypi (Closed)

Created:
7 years, 1 month ago by DaveMoore
Modified:
7 years, 1 month ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Upload w/out file matching #

Patch Set 3 : Remove invalid comment #

Patch Set 4 : Add mojom rule #

Patch Set 5 : Typo #

Patch Set 6 : Remove unneeded GYP stuff #

Patch Set 7 : Rename files, add python generation source to rules #

Patch Set 8 : Remove accidentally added .o's #

Patch Set 9 : Missing gypi file #

Total comments: 2

Patch Set 10 : rename parser to parsers to avoid Windows python bug #

Patch Set 11 : Merge problems #

Patch Set 12 : Merge Fallout #

Patch Set 13 : Add __init__ to mojo_parser #

Patch Set 14 : Undo unnecessary rename of parser to mojo_parser #

Patch Set 15 : One more rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -1040 lines) Patch
M mojo/DEPS View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M mojo/mojo.gyp View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +21 lines, -4 lines 0 comments Download
M mojo/public/bindings/mojo_idl.py View 1 2 3 4 5 6 1 chunk +0 lines, -43 lines 0 comments Download
A mojo/public/bindings/mojom_bindings_generator.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +46 lines, -0 lines 0 comments Download
A + mojo/public/bindings/mojom_bindings_generator.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +5 lines, -2 lines 0 comments Download
A + mojo/public/bindings/parse/__init__.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/bindings/parse/mojo_parser.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/bindings/parse/mojo_translate.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/public/bindings/parser/__init__.py View 1 2 3 4 5 6 7 8 9 14 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/public/bindings/parser/mojo_parser.py View 1 2 3 4 5 6 7 8 9 14 1 chunk +0 lines, -235 lines 0 comments Download
D mojo/public/bindings/parser/mojo_translate.py View 1 2 3 4 5 6 7 8 9 10 11 14 1 chunk +0 lines, -130 lines 0 comments Download
D mojo/public/bindings/sample/generated/sample_service.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -168 lines 0 comments Download
D mojo/public/bindings/sample/generated/sample_service.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -339 lines 0 comments Download
D mojo/public/bindings/sample/generated/sample_service_internal.h View 1 2 3 4 5 6 1 chunk +0 lines, -41 lines 0 comments Download
A + mojo/public/bindings/sample/mojom/sample_service.h View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/bindings/sample/mojom/sample_service.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/public/bindings/sample/mojom/sample_service_internal.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
D mojo/public/bindings/sample/sample_service.idl View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -39 lines 0 comments Download
M mojo/public/bindings/sample/sample_service.mojom View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +36 lines, -40 lines 0 comments Download
M mojo/public/bindings/sample/sample_test.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
DaveMoore
Remove invalid comment
7 years, 1 month ago (2013-11-05 03:34:09 UTC) #1
DaveMoore
Typo
7 years, 1 month ago (2013-11-08 19:29:31 UTC) #2
DaveMoore
Rename files, add python generation source to rules
7 years, 1 month ago (2013-11-08 21:47:44 UTC) #3
DaveMoore
Remove accidentally added .o's
7 years, 1 month ago (2013-11-08 21:50:23 UTC) #4
DaveMoore
7 years, 1 month ago (2013-11-08 21:52:08 UTC) #5
darin (slow to review)
It would be nice to give mojom_bindings_generator.py a shorter name. We should think of this ...
7 years, 1 month ago (2013-11-09 00:33:36 UTC) #6
darin (slow to review)
It looks like you did not upload the .gypi file.
7 years, 1 month ago (2013-11-09 00:34:00 UTC) #7
DaveMoore
Missing gypi file
7 years, 1 month ago (2013-11-11 16:49:00 UTC) #8
darin (slow to review)
LGTM https://codereview.chromium.org/53173008/diff/370001/build/mojom_bindings_generator.gypi File build/mojom_bindings_generator.gypi (right): https://codereview.chromium.org/53173008/diff/370001/build/mojom_bindings_generator.gypi#newcode1 build/mojom_bindings_generator.gypi:1: # Copyright (c) 2012 The Chromium Authors. All ...
7 years, 1 month ago (2013-11-11 17:00:02 UTC) #9
DaveMoore
Committed patchset #9 manually as r234233 (presubmit successful).
7 years, 1 month ago (2013-11-11 17:30:40 UTC) #10
DaveMoore
rename parser to parsers to avoid Windows python bug
7 years, 1 month ago (2013-11-12 02:37:13 UTC) #11
DaveMoore
Merge Fallout
7 years, 1 month ago (2013-11-13 16:41:18 UTC) #12
DaveMoore
Undo unnecessary rename of parser to mojo_parser
7 years, 1 month ago (2013-11-13 18:21:44 UTC) #13
DaveMoore
One more rename
7 years, 1 month ago (2013-11-13 19:17:12 UTC) #14
DaveMoore
7 years, 1 month ago (2013-11-13 20:45:55 UTC) #15
Message was sent while issue was closed. 
Committed patchset #15 manually as r234895 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698