Issue 692333006: Revert "Parser & internalizing: efficiency fixes."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 692333006: Revert "Parser & internalizing: efficiency fixes." (Closed)

Created:
6 years, 1 month ago by Igor Sheludko

Modified:
6 years, 1 month ago

Reviewers:
marja

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Revert "Parser & internalizing: efficiency fixes." This reverts commit 94a08565d79a13056b9d964428798dac564905bc for breaking layout tests. TBR=marja@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25121

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -22 lines)			Patch
	M	src/ast-value-factory.cc	View		7 chunks	+10 lines, -17 lines	0 comments	Download
	M	src/parser.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

Committed patchset #1 (id:1) manually as 25121 (presubmit successful).

6 years, 1 month ago (2014-11-04 21:37:34 UTC) #1

Jakob Kummerow

This has a distinct smell of crbug.com/429270 to it. Might it be related?

6 years, 1 month ago (2014-11-04 22:06:13 UTC) #2

marja

6 years, 1 month ago (2014-11-05 09:00:49 UTC) #3

Message was sent while issue was closed.

On 2014/11/04 22:06:13, Jakob wrote:
> This has a distinct smell of crbug.com/429270 to it. Might it be related?

Hmm... "related" as in both seem to do with string internalization, but idk what
the connection would be. This was supposed to be an efficiency fix (no need to
gather stuff into data structures if we don't need it in the future) which
apparently went wrong.

Expand Messages | Collapse Messages