Chromium Code Reviews

Unified Diff: src/ast-value-factory.cc

Issue 692333006: Revert "Parser & internalizing: efficiency fixes." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | src/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast-value-factory.cc
diff --git a/src/ast-value-factory.cc b/src/ast-value-factory.cc
index 90c472d0825e55a18217db316e0e55d5cfbf590b..895ce39f652845fa83674d61ec98b0c9b8f1b5e1 100644
--- a/src/ast-value-factory.cc
+++ b/src/ast-value-factory.cc
@@ -241,11 +241,12 @@ const AstRawString* AstValueFactory::GetString(Handle<String> literal) {
const AstConsString* AstValueFactory::NewConsString(
const AstString* left, const AstString* right) {
+ // This Vector will be valid as long as the Collector is alive (meaning that
+ // the AstRawString will not be moved).
AstConsString* new_string = new (zone_) AstConsString(left, right);
+ strings_.Add(new_string);
if (isolate_) {
new_string->Internalize(isolate_);
- } else {
- strings_.Add(new_string);
}
return new_string;
}
@@ -272,12 +273,9 @@ const AstValue* AstValueFactory::NewString(const AstRawString* string) {
AstValue* value = new (zone_) AstValue(string);
DCHECK(string != NULL);
if (isolate_) {
- // If we're creating immediately-internalized AstValues, the underlying
- // strings must already be internalized at this point.
- DCHECK(!string->string_.is_null());
+ value->Internalize(isolate_);
}
- // These AstValues don't need to be added to values_, since the AstRawStrings
- // will be insternalized separately.
+ values_.Add(value);
return value;
}
@@ -286,9 +284,8 @@ const AstValue* AstValueFactory::NewSymbol(const char* name) {
AstValue* value = new (zone_) AstValue(name);
if (isolate_) {
value->Internalize(isolate_);
- } else {
- values_.Add(value);
}
+ values_.Add(value);
return value;
}
@@ -297,9 +294,8 @@ const AstValue* AstValueFactory::NewNumber(double number) {
AstValue* value = new (zone_) AstValue(number);
if (isolate_) {
value->Internalize(isolate_);
- } else {
- values_.Add(value);
}
+ values_.Add(value);
return value;
}
@@ -309,9 +305,8 @@ const AstValue* AstValueFactory::NewSmi(int number) {
new (zone_) AstValue(AstValue::SMI, number);
if (isolate_) {
value->Internalize(isolate_);
- } else {
- values_.Add(value);
}
+ values_.Add(value);
return value;
}
@@ -321,9 +316,8 @@ const AstValue* AstValueFactory::NewSmi(int number) {
value = new (zone_) AstValue(initializer); \
if (isolate_) { \
value->Internalize(isolate_); \
- } else { \
- values_.Add(value); \
} \
+ values_.Add(value); \
} \
return value;
@@ -370,10 +364,9 @@ const AstRawString* AstValueFactory::GetString(
AstRawString* new_string = new (zone_) AstRawString(
is_one_byte, Vector<const byte>(new_literal_bytes, length), hash);
entry->key = new_string;
+ strings_.Add(new_string);
if (isolate_) {
new_string->Internalize(isolate_);
- } else {
- strings_.Add(new_string);
}
entry->value = reinterpret_cast<void*>(1);
}
« no previous file with comments | « no previous file | src/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine