Disable -Wextra for all toolchains.

Disable -Wextra for all toolchains.

On clang, this flag is a no-op, and Blink code has a long way to go to be
clean with respect to these warnings on GCC toolchains. The GYP build has
never had -Wextra set, so let's just make GN in line with that.

BUG=424334
TEST=try bots
TBR=brettw

Committed: https://crrev.com/c9aa95f7873dc969f35cded9b4f2e2692af91b18
Cr-Commit-Position: refs/heads/master@{#302693}

[Chris Masone, 2014-11-01 06:43:02]

cmasone@chromium.org changed reviewers:
+ brettw@chromium.org, thakis@chromium.org

[Chris Masone, 2014-11-02 19:07:03]

cmasone@chromium.org changed reviewers:
+ scottmg@chromium.org

[Chris Masone, 2014-11-03 18:54:45]

Brett, can you give this a look?

[Nico, 2014-11-03 18:58:42]

https://codereview.chromium.org/692313002/diff/1/build/config/compiler/BUILD.gn
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/692313002/diff/1/build/config/compiler/BUILD....
build/config/compiler/BUILD.gn:532: "-Wextra",
I'd just remove this. -Wextra is a no-op in clang, and it's removed on all
non-clang platforms in gyp:
https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&...

[brettw, 2014-11-03 19:00:37]

Is this in sync with the GYP build?

[Chris Masone, 2014-11-03 19:02:41]

As Nico says, the GYP build doesn't set -Wextra at all, and scottmg said in
email that it was more-or-less aspirational.

Also, Blink code seems to have a long way to go to be clean WRT -Wextra, so I'm
just going to take it out.

/sadpanda.

[Chris Masone, 2014-11-03 20:17:37]

OK, PTAL

[Nico, 2014-11-03 20:30:10]

https://codereview.chromium.org/692313002/diff/20001/build/config/compiler/BU...
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/692313002/diff/20001/build/config/compiler/BU...
build/config/compiler/BUILD.gn:754: "-Wno-type-limits",
If you want to keep this, I'd add it to the gyp build too. Or remove this here.

[Chris Masone, 2014-11-03 20:34:14]

On 2014/11/03 20:30:10, Nico wrote:
>
https://codereview.chromium.org/692313002/diff/20001/build/config/compiler/BU...
> File build/config/compiler/BUILD.gn (right):
> 
>
https://codereview.chromium.org/692313002/diff/20001/build/config/compiler/BU...
> build/config/compiler/BUILD.gn:754: "-Wno-type-limits",
> If you want to keep this, I'd add it to the gyp build too. Or remove this
here.

I think I'll add it to the GYP build, as I'd like to record the knowledge
somewhere for posterity.

[Chris Masone, 2014-11-03 20:38:50]

https://codereview.chromium.org/692313002/diff/20001/build/config/compiler/BU...
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/692313002/diff/20001/build/config/compiler/BU...
build/config/compiler/BUILD.gn:754: "-Wno-type-limits",
On 2014/11/03 20:30:10, Nico wrote:
> If you want to keep this, I'd add it to the gyp build too. Or remove this
here.

Done.

[Nico, 2014-11-03 20:42:38]

https://codereview.chromium.org/692313002/diff/40001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/692313002/diff/40001/build/common.gypi#newcod...
build/common.gypi:3555: '-Wno-type-limits',
You only want to add this for gcc builds. clang builds are warning-free.

[Chris Masone, 2014-11-03 20:56:12]

removed any reference to type-limits. Knowledge recorded in
https://code.google.com/p/chromium/issues/detail?id=429804 for posterity

[Nico, 2014-11-03 20:56:44]

lgtm

[Chris Masone, 2014-11-03 21:30:33]

On 2014/11/03 20:56:44, Nico wrote:
> lgtm

Brett, can I haz an OWNER LGTM?

[Chris Masone, 2014-11-04 21:47:31]

On 2014/11/03 21:30:33, Chris Masone wrote:
> On 2014/11/03 20:56:44, Nico wrote:
> > lgtm
> 
> Brett, can I haz an OWNER LGTM?

Ping?

[Nico, 2014-11-04 21:53:19]

On 2014/11/04 21:47:31, Chris Masone wrote:
> On 2014/11/03 21:30:33, Chris Masone wrote:
> > On 2014/11/03 20:56:44, Nico wrote:
> > > lgtm
> > 
> > Brett, can I haz an OWNER LGTM?
> 
> Ping?

Since this matches gyp, I think it's fine to TBR=brettw this.

[Chris Masone, 2014-11-04 21:54:29]

The CQ bit was checked by cmasone@chromium.org

[commit-bot: I haz the power, 2014-11-04 21:56:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/692313002/60001

[brettw, 2014-11-04 22:32:36]

lgtm

[commit-bot: I haz the power, 2014-11-04 22:44:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-11-04 22:46:36]

Patchset 4 (id:??) landed as
https://crrev.com/c9aa95f7873dc969f35cded9b4f2e2692af91b18
Cr-Commit-Position: refs/heads/master@{#302693}