build/config/compiler/BUILD.gn - Issue 692313002: Disable -Wextra for all toolchains.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 692313002: Disable -Wextra for all toolchains. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: get rid of -Wno-type-limits altogether Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index b80fa16a684dcda2b2c925923b406cff2c9932f0..d0a27faec63f9f486ebed96310206db47ec9ae63 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -529,7 +529,6 @@ config("chromium_code") {

} else {

cflags = [

"-Wall",

- "-Wextra",

# GCC turns on -Wsign-compare for C++ under -Wall, but clang doesn't,

# so we specify it explicitly.

« no previous file with comments | « no previous file | no next file » | no next file with comments »