Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: components/autofill/core/browser/credit_card.cc

Issue 692233002: Use --no-output-all-resource-defines for grit on iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: readd a couple last resource IDs Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/credit_card.cc
diff --git a/components/autofill/core/browser/credit_card.cc b/components/autofill/core/browser/credit_card.cc
index 287814240247599ac822a4878e1650545c38b88c..fde4c69fad9dfbd568c71f3923746b7bbdc82340 100644
--- a/components/autofill/core/browser/credit_card.cc
+++ b/components/autofill/core/browser/credit_card.cc
@@ -161,6 +161,9 @@ base::string16 CreditCard::TypeForDisplay(const std::string& type) {
return base::string16();
}
+// This method is not compiled on iOS because the resources are not used and
+// should not be shipped.
+#if !defined(OS_IOS)
// static
int CreditCard::IconResourceId(const std::string& type) {
if (type == kAmericanExpressCard)
@@ -183,6 +186,7 @@ int CreditCard::IconResourceId(const std::string& type) {
DCHECK_EQ(kGenericCard, type);
return IDR_AUTOFILL_CC_GENERIC;
}
+#endif // #if !defined(OS_IOS)
// static
const char* CreditCard::GetCreditCardType(const base::string16& number) {
« no previous file with comments | « components/autofill/core/browser/credit_card.h ('k') | components/autofill/core/browser/credit_card_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698