grit/format/policy_templates/writers/admx_writer_unittest.py - Issue 692033002: Set the MAXLEN/maxLength attribute for strings in ADM[X] templates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: grit/format/policy_templates/writers/admx_writer_unittest.py

Issue 692033002: Set the MAXLEN/maxLength attribute for strings in ADM[X] templates. (Closed) Base URL: https://chromium.googlesource.com/external/grit-i18n.git@master

Patch Set: fixed upload Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « grit/format/policy_templates/writers/admx_writer.py ('k') | grit/format/policy_templates/writers/xml_formatted_writer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: grit/format/policy_templates/writers/admx_writer_unittest.py

diff --git a/grit/format/policy_templates/writers/admx_writer_unittest.py b/grit/format/policy_templates/writers/admx_writer_unittest.py

index cb3d39e9b16a5ee9b9c48427912437e42ed1b7fd..4fe66a95416806c004107f04c9c362addf4c5c75 100644

--- a/grit/format/policy_templates/writers/admx_writer_unittest.py

+++ b/grit/format/policy_templates/writers/admx_writer_unittest.py

@@ -276,7 +276,8 @@ class AdmxWriterUnittest(xml_writer_base_unittest.XmlWriterBaseTest):

' <parentCategory ref="PolicyGroup"/>\n'

' <supportedOn ref="SUPPORTED_TESTOS"/>\n'

' <elements>\n'

- ' <text id="SampleStringPolicy" valueName="SampleStringPolicy"/>\n'

+ ' <text id="SampleStringPolicy" maxLength="1000000"'

+ ' valueName="SampleStringPolicy"/>\n'

' </elements>\n'

'</policy>')

self.AssertXMLEquals(output, expected_output)

@@ -454,8 +455,8 @@ class AdmxWriterUnittest(xml_writer_base_unittest.XmlWriterBaseTest):

' <parentCategory ref="PolicyGroup"/>\n'

' <supportedOn ref="SUPPORTED_TESTOS"/>\n'

' <elements>\n'

- ' <text id="SampleDictionaryPolicy" '

- 'valueName="SampleDictionaryPolicy"/>\n'

+ ' <text id="SampleDictionaryPolicy" maxLength="1000000"'

+ ' valueName="SampleDictionaryPolicy"/>\n'

' </elements>\n'

'</policy>')

self.AssertXMLEquals(output, expected_output)