grit/format/policy_templates/writers/admx_writer.py - Issue 692033002: Set the MAXLEN/maxLength attribute for strings in ADM[X] templates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: grit/format/policy_templates/writers/admx_writer.py

Issue 692033002: Set the MAXLEN/maxLength attribute for strings in ADM[X] templates. (Closed) Base URL: https://chromium.googlesource.com/external/grit-i18n.git@master

Patch Set: fixed upload Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « grit/format/policy_templates/writers/adm_writer_unittest.py ('k') | grit/format/policy_templates/writers/admx_writer_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: grit/format/policy_templates/writers/admx_writer.py

diff --git a/grit/format/policy_templates/writers/admx_writer.py b/grit/format/policy_templates/writers/admx_writer.py

index ceba51416c31ef6c9e38e62e0b34e4012d467324..37be4ab921ad36cd20d36a0aaf833f2c690e50a5 100644

--- a/grit/format/policy_templates/writers/admx_writer.py

+++ b/grit/format/policy_templates/writers/admx_writer.py

@@ -167,6 +167,7 @@ class ADMXWriter(xml_formatted_writer.XMLFormattedWriter):

attributes = {

'id': name,

'valueName': name,

+ 'maxLength': '1000000',

}

self.AddElement(parent, 'text', attributes)