Source/web/WebSharedWorkerImpl.h - Issue 692003002: ServiceWorker: Registering a malformed script should fail [1/3]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebSharedWorkerImpl.h

Issue 692003002: ServiceWorker: Registering a malformed script should fail [1/3] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address falken@'s comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebSharedWorkerImpl.h

diff --git a/Source/web/WebSharedWorkerImpl.h b/Source/web/WebSharedWorkerImpl.h

index ff85226d11be1728f410526db1b4ac8d3a0cfe9a..91529f92bfa68b5c18505d54fb13a5637301853e 100644

--- a/Source/web/WebSharedWorkerImpl.h

+++ b/Source/web/WebSharedWorkerImpl.h

@@ -75,6 +75,7 @@ public:

const WTF::String&, int, int, const WTF::String&) override;

virtual void reportConsoleMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>) override;

virtual void postMessageToPageInspector(const WTF::String&) override;

+ virtual void workerScriptEvaluated(bool success) override { };

virtual void workerGlobalScopeStarted(WorkerGlobalScope*) override;

virtual void workerGlobalScopeClosed() override;

virtual void workerThreadTerminated() override;

« Source/core/workers/WorkerThread.cpp ('K') | « Source/web/ServiceWorkerGlobalScopeProxy.cpp ('k') | public/web/WebServiceWorkerContextClient.h » ('j') | no next file with comments »