Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 691863003: Add a setting to do frame scrolls through the root layer. (Closed)

Created:
6 years, 1 month ago by skobes
Modified:
6 years, 1 month ago
CC:
blink-reviews, kenneth.christiansen, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, blink-reviews-events_chromium.org, dglazkov+blink, jchaffraix+rendering
Project:
blink
Visibility:
Public.

Description

Add a setting to do frame scrolls through the root layer. BUG=417782 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184810

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -14 lines) Patch
M Source/core/frame/FrameView.cpp View 5 chunks +13 lines, -2 lines 0 comments Download
M Source/core/frame/Settings.in View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/paint/BlockPainter.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/paint/BlockPainter.cpp View 1 chunk +8 lines, -2 lines 0 comments Download
M Source/core/paint/ViewPainter.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderLayerClipper.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M Source/web/WebSettingsImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebSettings.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
skobes
Early stages. Lots of things don't work yet (threaded scrolling, position:fixed...).
6 years, 1 month ago (2014-10-31 00:03:35 UTC) #2
Ian Vollick
On 2014/10/31 00:03:35, skobes wrote: > Early stages. Lots of things don't work yet (threaded ...
6 years, 1 month ago (2014-10-31 20:07:17 UTC) #3
skobes
+japhet for OWNERS
6 years, 1 month ago (2014-11-03 23:42:52 UTC) #5
Nate Chapin
Source/web and public/web LGTM
6 years, 1 month ago (2014-11-03 23:46:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691863003/1
6 years, 1 month ago (2014-11-03 23:56:02 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 23:59:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184810

Powered by Google App Engine
This is Rietveld 408576698