Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 691803004: styleguide: ban inherited constructors (Closed)

Created:
6 years, 1 month ago by mdempsky
Modified:
6 years, 1 month ago
Reviewers:
Nico, mdempsky_google
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

styleguide: ban inherited constructors Committed: https://crrev.com/33bafda741776ba2595c4adb56a4851a51156339 Cr-Commit-Position: refs/heads/master@{#302188}

Patch Set 1 #

Total comments: 4

Patch Set 2 : s/will list/lists/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M styleguide/c++/c++11.html View 1 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
mdempsky
6 years, 1 month ago (2014-10-30 21:05:32 UTC) #2
Nico
lgtm, thanks! https://codereview.chromium.org/691803004/diff/1/styleguide/c++/c++11.html File styleguide/c++/c++11.html (right): https://codereview.chromium.org/691803004/diff/1/styleguide/c++/c++11.html#newcode200 styleguide/c++/c++11.html:200: <p>This section will list C++11 features that ...
6 years, 1 month ago (2014-10-30 22:11:04 UTC) #3
mdempsky_google
https://codereview.chromium.org/691803004/diff/1/styleguide/c++/c++11.html File styleguide/c++/c++11.html (right): https://codereview.chromium.org/691803004/diff/1/styleguide/c++/c++11.html#newcode200 styleguide/c++/c++11.html:200: <p>This section will list C++11 features that are not ...
6 years, 1 month ago (2014-10-30 22:19:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691803004/20001
6 years, 1 month ago (2014-10-30 22:20:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-30 23:15:02 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 23:15:43 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/33bafda741776ba2595c4adb56a4851a51156339
Cr-Commit-Position: refs/heads/master@{#302188}

Powered by Google App Engine
This is Rietveld 408576698