Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: styleguide/c++/c++11.html

Issue 691803004: styleguide: ban inherited constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: s/will list/lists/ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: styleguide/c++/c++11.html
diff --git a/styleguide/c++/c++11.html b/styleguide/c++/c++11.html
index c0274d97fb02529c7dd7cc7b242d7711f46adf66..6d870fbd0e39caf68bfbc4ebb072dd60a601d3cf 100644
--- a/styleguide/c++/c++11.html
+++ b/styleguide/c++/c++11.html
@@ -197,7 +197,7 @@ Are Variadic macros nonstandard?</a></td>
<h3 id="blacklist_banned">C++11 Banned Features</h3>
-<p>This section will list C++11 features that are not allowed in the Chromium
+<p>This section lists C++11 features that are not allowed in the Chromium
codebase.
</p>
@@ -243,6 +243,17 @@ The __func__ Predeclared Identifier is Coming to C++</a></td>
</tr>
<tr>
+<td>Inherited Constructors</td>
+<td><code>class Derived : Base {
+<br />&nbsp;&nbsp;using Base::Base;
+<br />};</code></td>
+<td>Allow derived classes to inherit constructors from base classes</td>
+<td><a href="http://en.cppreference.com/w/cpp/language/using_declaration">Using-declaration</a></td>
+<td>Doesn't work in MSVS2013. Reevaluate once it does. <a
+href="https://groups.google.com/a/chromium.org/d/msg/chromium-dev/BULzgIKZ-Ao/PLO7_GoVNvYJ">Discussion thread</a></td>
+</tr>
+
+<tr>
<td><code>long long</code> Type</td>
<td><code>long long <i>var</i>= <i>value</i>;</code></td>
<td>An integer of at least 64 bits</td>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698