Factor out loading & running of DSOs

Factor out loading & running of DSOs

BUG=
R=viettrungluu@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/3a99b93bd500078fc8a045b70e89d47446196d42

[DaveMoore, 2014-10-29 22:12:10]

Extra import

[DaveMoore, 2014-10-29 22:15:12]

davemoore@chromium.org changed reviewers:
+ viettrungluu@chromium.org

[DaveMoore, 2014-10-29 22:15:13]

https://codereview.chromium.org/691653002/diff/20001/mojo/shell/app_child_pro...
File mojo/shell/app_child_process.cc (right):

https://codereview.chromium.org/691653002/diff/20001/mojo/shell/app_child_pro...
mojo/shell/app_child_process.cc:230: base::ScopedNativeLibrary app_library(
This keeps the semantics of unloading the library. It's possible we shouldn't
bother here though as the process is going away.

[viettrungluu, 2014-10-29 23:11:43]

https://codereview.chromium.org/691653002/diff/20001/mojo/shell/app_child_pro...
File mojo/shell/app_child_process.cc (right):

https://codereview.chromium.org/691653002/diff/20001/mojo/shell/app_child_pro...
mojo/shell/app_child_process.cc:230: base::ScopedNativeLibrary app_library(
On 2014/10/29 22:15:13, DaveMoore wrote:
> This keeps the semantics of unloading the library. It's possible we shouldn't
> bother here though as the process is going away.

We probably shouldn't. (I don't know if TLS destructors are fired when a process
exits in a normal way. Probably they do.)

https://codereview.chromium.org/691653002/diff/20001/mojo/shell/dynamic_servi...
File mojo/shell/dynamic_service_runner.cc (right):

https://codereview.chromium.org/691653002/diff/20001/mojo/shell/dynamic_servi...
mojo/shell/dynamic_service_runner.cc:39: }
Needs a newline above and a "// namespace" comment.

https://codereview.chromium.org/691653002/diff/20001/mojo/shell/dynamic_servi...
File mojo/shell/dynamic_service_runner.h (right):

https://codereview.chromium.org/691653002/diff/20001/mojo/shell/dynamic_servi...
mojo/shell/dynamic_service_runner.h:36: // execution. Runs the exported function
MojoMain() and blocks until it
Just say "Runs the DSO's exported MojoMain() on the current thread."

https://codereview.chromium.org/691653002/diff/20001/mojo/shell/dynamic_servi...
mojo/shell/dynamic_service_runner.h:38: // The NativeLibrary is returned and
ownership transfered to the caller.
"transfered" -> "transferred"

https://codereview.chromium.org/691653002/diff/20001/mojo/shell/dynamic_servi...
mojo/shell/dynamic_service_runner.h:39: // This is primarilly so if it is to be
unloaded through
"primarilly" -> "primarily"

Maybe just say:

This is so if it is unloaded at all, this can be done safely after this thread
is destroyed and any thread-local destructors have been executed.

[DaveMoore, 2014-10-30 15:32:34]

Review nits

[DaveMoore, 2014-10-30 15:32:56]

https://codereview.chromium.org/691653002/diff/20001/mojo/shell/app_child_pro...
File mojo/shell/app_child_process.cc (right):

https://codereview.chromium.org/691653002/diff/20001/mojo/shell/app_child_pro...
mojo/shell/app_child_process.cc:230: base::ScopedNativeLibrary app_library(
On 2014/10/29 23:11:43, viettrungluu wrote:
> On 2014/10/29 22:15:13, DaveMoore wrote:
> > This keeps the semantics of unloading the library. It's possible we
shouldn't
> > bother here though as the process is going away.
> 
> We probably shouldn't. (I don't know if TLS destructors are fired when a
process
> exits in a normal way. Probably they do.)

Done.

https://codereview.chromium.org/691653002/diff/20001/mojo/shell/dynamic_servi...
File mojo/shell/dynamic_service_runner.cc (right):

https://codereview.chromium.org/691653002/diff/20001/mojo/shell/dynamic_servi...
mojo/shell/dynamic_service_runner.cc:39: }
On 2014/10/29 23:11:43, viettrungluu wrote:
> Needs a newline above and a "// namespace" comment.

Done.

https://codereview.chromium.org/691653002/diff/20001/mojo/shell/dynamic_servi...
File mojo/shell/dynamic_service_runner.h (right):

https://codereview.chromium.org/691653002/diff/20001/mojo/shell/dynamic_servi...
mojo/shell/dynamic_service_runner.h:36: // execution. Runs the exported function
MojoMain() and blocks until it
On 2014/10/29 23:11:43, viettrungluu wrote:
> Just say "Runs the DSO's exported MojoMain() on the current thread."

Done.

https://codereview.chromium.org/691653002/diff/20001/mojo/shell/dynamic_servi...
mojo/shell/dynamic_service_runner.h:38: // The NativeLibrary is returned and
ownership transfered to the caller.
On 2014/10/29 23:11:43, viettrungluu wrote:
> "transfered" -> "transferred"

Done.

https://codereview.chromium.org/691653002/diff/20001/mojo/shell/dynamic_servi...
mojo/shell/dynamic_service_runner.h:39: // This is primarilly so if it is to be
unloaded through
On 2014/10/29 23:11:43, viettrungluu wrote:
> "primarilly" -> "primarily"
> 
> Maybe just say:
> 
> This is so if it is unloaded at all, this can be done safely after this thread
> is destroyed and any thread-local destructors have been executed.

Done.

[viettrungluu, 2014-10-30 15:37:31]

lgtm

[DaveMoore, 2014-10-30 15:40:15]

Committed patchset #3 (id:40001) manually as
3a99b93bd500078fc8a045b70e89d47446196d42 (presubmit successful).