mojo/shell/in_process_dynamic_service_runner.h - Issue 691653002: Factor out loading & running of DSOs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/shell/in_process_dynamic_service_runner.h

Issue 691653002: Factor out loading & running of DSOs (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Review nits Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/shell/in_process_dynamic_service_runner.h

diff --git a/mojo/shell/in_process_dynamic_service_runner.h b/mojo/shell/in_process_dynamic_service_runner.h

index 9b93ded9131c78726610a05f19d0d20231c9d910..3719f36973fcb7d69eef298cc1fdb55a1df5fbad 100644

--- a/mojo/shell/in_process_dynamic_service_runner.h

+++ b/mojo/shell/in_process_dynamic_service_runner.h

@@ -8,7 +8,6 @@

#include "base/callback.h"

#include "base/files/file_path.h"

#include "base/macros.h"

-#include "base/scoped_native_library.h"

#include "base/threading/simple_thread.h"

#include "mojo/shell/dynamic_service_runner.h"

@@ -37,7 +36,7 @@ class InProcessDynamicServiceRunner

ScopedMessagePipeHandle service_handle_;

base::Callback<bool(void)> app_completed_callback_runner_;

- base::ScopedNativeLibrary app_library_;

+ base::NativeLibrary app_library_;

scoped_ptr<base::DelegateSimpleThread> thread_;

DISALLOW_COPY_AND_ASSIGN(InProcessDynamicServiceRunner);