Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 691553004: Record stack trace and coarse reason for referrer failures (Closed)

Created:
6 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
6 years, 1 month ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Record stack trace and coarse reason for referrer failures BUG=422871 R=mmenke@chromium.org Committed: https://crrev.com/b93dba3c71cb88ffb9f78ef0277ab7e990e43461 Cr-Commit-Position: refs/heads/master@{#303596}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M chrome/browser/net/chrome_network_delegate.cc View 1 3 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
jochen (gone - plz use gerrit)
6 years, 1 month ago (2014-11-09 22:20:31 UTC) #1
mmenke
LGTM https://codereview.chromium.org/691553004/diff/1/chrome/browser/net/chrome_network_delegate.cc File chrome/browser/net/chrome_network_delegate.cc (right): https://codereview.chromium.org/691553004/diff/1/chrome/browser/net/chrome_network_delegate.cc#newcode233 chrome/browser/net/chrome_network_delegate.cc:233: const base::debug::StackTrace& callstack) { Maybe add a comment ...
6 years, 1 month ago (2014-11-10 15:14:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691553004/20001
6 years, 1 month ago (2014-11-10 19:32:38 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/20718)
6 years, 1 month ago (2014-11-10 20:16:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691553004/20001
6 years, 1 month ago (2014-11-10 20:27:39 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/20754)
6 years, 1 month ago (2014-11-10 21:05:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691553004/20001
6 years, 1 month ago (2014-11-11 05:10:16 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-11 05:28:49 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 05:29:26 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b93dba3c71cb88ffb9f78ef0277ab7e990e43461
Cr-Commit-Position: refs/heads/master@{#303596}

Powered by Google App Engine
This is Rietveld 408576698