Record stack trace and coarse reason for referrer failures

chrome/browser/net/chrome_network_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/net/chrome_network_delegate.h"
 
 #include <stdlib.h>
 
 #include <vector>
 
 #include "base/base_paths.h"
+#include "base/debug/alias.h"
 #include "base/debug/dump_without_crashing.h"
+#include "base/debug/stack_trace.h"
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/metrics/user_metrics.h"
 #include "base/path_service.h"
 #include "base/prefs/pref_member.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/time/time.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 197 matching lines @@
 void RecordIOThreadToRequestStartOnUIThread(
     const base::TimeTicks& request_start) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   base::TimeDelta request_lag = request_start -
       g_browser_process->io_thread()->creation_time();
   UMA_HISTOGRAM_TIMES("Net.IOThreadCreationToHTTPRequestStart", request_lag);
 }
 #endif  // defined(OS_ANDROID)
 
 void ReportInvalidReferrerSend(const GURL& target_url,
-                               const GURL& referrer_url) {
+                               const GURL& referrer_url,
+                               const base::debug::StackTrace& callstack) {

[mmenke, 2014/11/10 15:14:29]

Maybe add a comment with the bug ID?

+  base::debug::StackTrace trace = callstack;
+  base::debug::Alias(&trace);
+  enum { INVALID_URL, FILE_URL, DATA_URL, HTTP_URL, OTHER } reason = OTHER;
+  if (!target_url.is_valid())
+    reason = INVALID_URL;
+  else if (target_url.SchemeIsFile())
+    reason = FILE_URL;
+  else if (target_url.SchemeIs(url::kDataScheme))
+    reason = DATA_URL;
+  else if (target_url.SchemeIs(url::kHttpScheme))
+    reason = HTTP_URL;
+  base::debug::Alias(&reason);
   base::RecordAction(
       base::UserMetricsAction("Net.URLRequest_StartJob_InvalidReferrer"));
   base::debug::DumpWithoutCrashing();
   NOTREACHED();
 }
 
 }  // namespace
 
 ChromeNetworkDelegate::ChromeNetworkDelegate(
     extensions::EventRouterForwarder* event_router,
@@ skipping 544 matching lines @@
   bool setting_cookie_allowed = cookie_settings_->IsSettingCookieAllowed(
       url, first_party_for_cookies);
   bool privacy_mode = !(reading_cookie_allowed && setting_cookie_allowed);
   return privacy_mode;
 }
 
 bool ChromeNetworkDelegate::OnCancelURLRequestWithPolicyViolatingReferrerHeader(
     const net::URLRequest& request,
     const GURL& target_url,
     const GURL& referrer_url) const {
+  base::debug::StackTrace callstack;
   BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
-      base::Bind(&ReportInvalidReferrerSend, target_url, referrer_url));
+                          base::Bind(&ReportInvalidReferrerSend, target_url,
+                                     referrer_url, callstack));
   return true;
 }
 
 void ChromeNetworkDelegate::AccumulateContentLength(
     int64 received_content_length,
     int64 original_content_length,
     data_reduction_proxy::DataReductionProxyRequestType request_type) {
   DCHECK_GE(received_content_length, 0);
   DCHECK_GE(original_content_length, 0);
   if (data_reduction_proxy_statistics_prefs_) {
     StoreAccumulatedContentLength(received_content_length,
                                   original_content_length,
                                   request_type,
                                   reinterpret_cast<Profile*>(profile_),
                                   data_reduction_proxy_statistics_prefs_);
   }
   received_content_length_ += received_content_length;
   original_content_length_ += original_content_length;
 }