Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 691483003: Land Recent QUIC Changes. (Closed)

Created:
6 years, 1 month ago by ramant (doing other things)
Modified:
6 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, alyssar, Ian Swett, rjshade, Jana
Base URL:
https://chromium.googlesource.com/chromium/src.git@Final_1028
Project:
chromium
Visibility:
Public.

Description

Land Recent QUIC Changes. Refactor Cubic congestion control to separate out PRR into a distinct class. Merge internal change: 78703144 https://codereview.chromium.org/688593002/ Move receive_window_ from BbrTcpSender and TcpCubicSender to QuicSentPacketManager, since it's not specific to a congestion algorithm. Merge internal change: 78692549 https://codereview.chromium.org/687093002/ Gathering ClientConnectionStats at suitable times (near the end of request handling and after receiving final ACK). Exported kNumberOfNacksBeforeRetransmission for gathering ClientConnectionStats. Merge internal change: 78688302 https://codereview.chromium.org/687083002/ Deprecate rolled out flag FLAGS_close_quic_connection_unfinished_streams_2 Merge internal change: 78683497 https://codereview.chromium.org/639823010/ Close the QUIC connection if too many sent or received packets are outstanding. Protected by FLAGS_quic_too_many_outstanding_packets. Merge internal change: 78666674 https://codereview.chromium.org/682413002/ Remove QUIC_VERSION_21 from supported versions. Will remove it entirely later, after QUIC_VERSION_19 is removed. Merge internal change: 78604601 https://codereview.chromium.org/682383003/ Turning off CID truncation for proxied connections. Turning on CID truncation by default, since chrome will do it by default. Turning off CID truncation for proxied connections for QUIC. Merge internal change: 78599095 https://codereview.chromium.org/683263003/ Protect UpdateRTT from negative send deltas Prevent negative send_deltas from being incorporated into the various RTT calculations. AFAIK, it's not happening now, but it doesn't hurt to be vigilant against future bugs. If we're getting such RTTs, it's due to some pathological error that we'd like to know about. Added a unittest for these corner cases. Low-impact. Don't use negative samples in QUIC rtt calculation. Merge internal change: 78580114 https://codereview.chromium.org/687883002/ Protect against the divide by zero error in QuicBandwidth::TransferTime. Currently some send algorithms may return QuicBandwidth::Zero. Merge internal change: 78578198 https://codereview.chromium.org/684043002/ Add a QUIC connection option, 'NTLP', to disable tail loss probes by setting max_tail_loss_probes_ to 0, in order to evaluate it's performance benefit. Merge internal change: 78465187 https://codereview.chromium.org/682283003/ Adding an option for peers to negotiate the length of the QUIC connection ID sent to them. This is a functional no-op until Chrome starts sending this configuration option, at which point it can still be turned off via FLAGS_allow_truncated_connection_ids_for_quic Also fixing quic config to not have protected member variables while I'm in there, because it was irritating me. Allowing truncated QUIC connection IDs. Off by default. Merge internal change: 78462599 https://codereview.chromium.org/687033002/ R=rch@chromium.org Committed: https://crrev.com/2318668785bae416e25ee3ffff0dd72308f075a9 Cr-Commit-Position: refs/heads/master@{#302014}

Patch Set 1 #

Patch Set 2 : Compilation error fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+778 lines, -183 lines) Patch
M net/net.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/congestion_control/pacing_sender.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/congestion_control/pacing_sender.cc View 1 chunk +0 lines, -7 lines 0 comments Download
A net/quic/congestion_control/prr_sender.h View 1 chunk +43 lines, -0 lines 0 comments Download
A net/quic/congestion_control/prr_sender.cc View 1 chunk +69 lines, -0 lines 0 comments Download
A net/quic/congestion_control/prr_sender_test.cc View 1 chunk +134 lines, -0 lines 0 comments Download
M net/quic/congestion_control/rtt_stats.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M net/quic/congestion_control/rtt_stats_test.cc View 1 2 chunks +38 lines, -0 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.h View 2 chunks +1 line, -5 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.h View 4 chunks +2 lines, -23 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 10 chunks +14 lines, -69 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 4 chunks +7 lines, -9 lines 0 comments Download
M net/quic/congestion_control/tcp_loss_algorithm.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/congestion_control/tcp_loss_algorithm.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M net/quic/crypto/crypto_protocol.h View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/quic_bandwidth.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_bandwidth_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_config.h View 3 chunks +14 lines, -0 lines 0 comments Download
M net/quic/quic_config.cc View 11 chunks +30 lines, -8 lines 0 comments Download
M net/quic/quic_connection.h View 4 chunks +14 lines, -0 lines 0 comments Download
M net/quic/quic_connection.cc View 7 chunks +35 lines, -2 lines 0 comments Download
M net/quic/quic_connection_test.cc View 7 chunks +104 lines, -4 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_flags.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M net/quic/quic_framer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/quic/quic_packet_creator.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/quic_packet_creator_test.cc View 4 chunks +18 lines, -4 lines 0 comments Download
M net/quic/quic_packet_generator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M net/quic/quic_packet_generator_test.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M net/quic/quic_protocol.h View 4 chunks +9 lines, -3 lines 0 comments Download
M net/quic/quic_received_packet_manager.h View 2 chunks +6 lines, -1 line 0 comments Download
M net/quic/quic_received_packet_manager.cc View 1 chunk +5 lines, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 4 chunks +15 lines, -2 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 4 chunks +64 lines, -2 lines 0 comments Download
M net/quic/quic_session.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_session_test.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_utils.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_config_peer.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_config_peer.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.h View 1 chunk +11 lines, -5 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.cc View 2 chunks +23 lines, -11 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_client.h View 2 chunks +2 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ramant (doing other things)
6 years, 1 month ago (2014-10-29 14:09:04 UTC) #1
Ryan Hamilton
lgtm
6 years, 1 month ago (2014-10-29 22:45:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691483003/20001
6 years, 1 month ago (2014-10-30 01:05:02 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-30 01:49:45 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 01:50:24 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2318668785bae416e25ee3ffff0dd72308f075a9
Cr-Commit-Position: refs/heads/master@{#302014}

Powered by Google App Engine
This is Rietveld 408576698