net/quic/congestion_control/rtt_stats.cc - Issue 691483003: Land Recent QUIC Changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/congestion_control/rtt_stats.cc

Issue 691483003: Land Recent QUIC Changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Final_1028

Patch Set: Compilation error fixes Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/congestion_control/rtt_stats.cc

diff --git a/net/quic/congestion_control/rtt_stats.cc b/net/quic/congestion_control/rtt_stats.cc

index 9b1e9470024b79bdb210d4aa2ac1535925713778..7b25b6c6d373268a76a2085e4f20b056d859e41d 100644

--- a/net/quic/congestion_control/rtt_stats.cc

+++ b/net/quic/congestion_control/rtt_stats.cc

@@ -53,9 +53,10 @@ void RttStats::ExpireSmoothedMetrics() {

void RttStats::UpdateRtt(QuicTime::Delta send_delta,

QuicTime::Delta ack_delay,

QuicTime now) {

- if (send_delta.IsInfinite() || send_delta.IsZero()) {

- DVLOG(1) << "Ignoring measured send_delta, because it's "

- << (send_delta.IsZero() ? "Zero" : "Infinite");

+ if (send_delta.IsInfinite() || send_delta <= QuicTime::Delta::Zero()) {

+ LOG(WARNING) << "Ignoring measured send_delta, because it's is "

+ << "either infinite, zero, or negative. send_delta = "

+ << send_delta.ToMicroseconds();

return;

}