Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(22)

Issue 6914029: We assume that each SkDevice is our custom PlatformDevice. This assumption is not valid when usin... (Closed)

Created:
8 years, 6 months ago by alokp
Modified:
8 years, 5 months ago
Reviewers:
Jeff Timanus, sky, reed1
CC:
chromium-reviews, Vangelis Kokkevis
Visibility:
Public.

Description

We assume that each SkDevice is our custom PlatformDevice. This assumption is not valid when using skia gpu path. This patch adds a "bool" meta-data to our custom PlatformDevice to properly identify them before performing the cast. This is a temporary hack for me to move forward with the gpu path. twiz@ is working on a long term solution that eliminates the need for subclassing SkDevice. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86867

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M ui/gfx/native_theme_win.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
alokp
8 years, 6 months ago (2011-05-03 20:34:18 UTC) #1
reed1
LGTM
8 years, 6 months ago (2011-05-03 20:55:27 UTC) #2
sky
LGTM
8 years, 6 months ago (2011-05-03 22:02:27 UTC) #3
Jeff Timanus
8 years, 6 months ago (2011-05-04 21:22:47 UTC) #4
LGTM

http://codereview.chromium.org/6914029/diff/1/skia/ext/platform_canvas.cc
File skia/ext/platform_canvas.cc (right):

http://codereview.chromium.org/6914029/diff/1/skia/ext/platform_canvas.cc#new...
skia/ext/platform_canvas.cc:12: static const char* kPlatformDeviceIdentifier =
"CrPlatformDevice";
Style guide nit/question.  Does static have any meaning in an unnamed
named-space in a .cc translation unit?

Powered by Google App Engine
This is Rietveld 408576698