Source/core/html/track/TextTrack.h - Issue 691313002: MSE: Implement TrackDefault object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/TextTrack.h

Issue 691313002: MSE: Implement TrackDefault object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address (most of) philipj@'s PS7 comments and add one more test Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/track/TextTrack.h

diff --git a/Source/core/html/track/TextTrack.h b/Source/core/html/track/TextTrack.h

index 137b6439d2685470fde346dc61fd35b11c8b057a..6e429481a7fad3cc442f6ddc04f0c18089bf9cc4 100644

--- a/Source/core/html/track/TextTrack.h

+++ b/Source/core/html/track/TextTrack.h

@@ -64,7 +64,7 @@ public:

static const AtomicString& descriptionsKeyword();

static const AtomicString& chaptersKeyword();

static const AtomicString& metadataKeyword();

- static bool isValidKindKeyword(const AtomicString&);

+ static bool isValidKindKeyword(const String&);

static const AtomicString& disabledKeyword();

static const AtomicString& hiddenKeyword();