Source/core/html/track/TextTrack.cpp - Issue 691313002: MSE: Implement TrackDefault object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/TextTrack.cpp

Issue 691313002: MSE: Implement TrackDefault object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address (most of) philipj@'s PS7 comments and add one more test Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/track/TextTrack.cpp

diff --git a/Source/core/html/track/TextTrack.cpp b/Source/core/html/track/TextTrack.cpp

index b95a35dbef448af17805b09669f465e226735144..6b3941845c9482fde2e97b674bd062f5735bcfeb 100644

--- a/Source/core/html/track/TextTrack.cpp

+++ b/Source/core/html/track/TextTrack.cpp

@@ -125,7 +125,7 @@ TextTrack::~TextTrack()

#endif

}

-bool TextTrack::isValidKindKeyword(const AtomicString& value)

+bool TextTrack::isValidKindKeyword(const String& value)

{

if (value == subtitlesKeyword())

return true;