Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Unified Diff: Source/core/html/track/AudioTrack.cpp

Issue 691313002: MSE: Implement TrackDefault object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address sof@'s PS6 comments and add a couple tests for constructor TypeError Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/track/AudioTrack.cpp
diff --git a/Source/core/html/track/AudioTrack.cpp b/Source/core/html/track/AudioTrack.cpp
index ac8c92e96418b4e35fbd7741a6fe5b1277a771ba..ef994d09212c71c3ea1ef012e6f7d5bdb517af23 100644
--- a/Source/core/html/track/AudioTrack.cpp
+++ b/Source/core/html/track/AudioTrack.cpp
@@ -67,14 +67,26 @@ const AtomicString& AudioTrack::commentaryKeyword()
return keyword;
}
-bool AudioTrack::isValidKind(const AtomicString& kind) const
+bool AudioTrack::isValidKindKeyword(const AtomicString& kind)
{
return (kind == alternativeKeyword())
|| (kind == descriptionsKeyword())
|| (kind == mainKeyword())
|| (kind == mainDescriptionsKeyword())
|| (kind == translationKeyword())
- || (kind == commentaryKeyword());
+ || (kind == commentaryKeyword())
+ || (kind == emptyAtom);
philipj_slow 2014/11/14 12:03:37 Can you add to the commit message the reason why t
wolenetz 2014/11/17 21:51:07 Done.
+}
+
+bool AudioTrack::isValidKindKeyword(const String& kind)
philipj_slow 2014/11/14 12:03:37 AtomicString is free to convert to String (and has
wolenetz 2014/11/17 21:51:07 Done.
+{
+ return (kind == alternativeKeyword())
+ || (kind == descriptionsKeyword())
+ || (kind == mainKeyword())
+ || (kind == mainDescriptionsKeyword())
+ || (kind == translationKeyword())
+ || (kind == commentaryKeyword())
+ || (kind == emptyAtom);
}
AtomicString AudioTrack::defaultKind() const

Powered by Google App Engine
This is Rietveld 408576698