Source/core/html/track/AudioTrack.h - Issue 691313002: MSE: Implement TrackDefault object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/AudioTrack.h

Issue 691313002: MSE: Implement TrackDefault object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address sof@'s PS6 comments and add a couple tests for constructor TypeError Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/track/AudioTrack.h

diff --git a/Source/core/html/track/AudioTrack.h b/Source/core/html/track/AudioTrack.h

index d084a441642c7a899df16d047efae146ef4429db..db5bae8aab81accdc27bb3854a76e3baaff471e4 100644

--- a/Source/core/html/track/AudioTrack.h

+++ b/Source/core/html/track/AudioTrack.h

@@ -30,11 +30,14 @@ public:

static const AtomicString& translationKeyword();

static const AtomicString& commentaryKeyword();

+ static bool isValidKindKeyword(const AtomicString&);

+ static bool isValidKindKeyword(const String&);

private:

AudioTrack(const String& id, const AtomicString& kind, const AtomicString& label, const AtomicString& language, bool enabled);

// TrackBase

- virtual bool isValidKind(const AtomicString&) const override;

+ virtual bool isValidKind(const AtomicString& kind) const override { return isValidKindKeyword(kind); }

virtual AtomicString defaultKind() const override;

bool m_enabled;