Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Issue 691223003: Remove some more assorted code from RenderBox. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -111 lines) Patch
M sky/engine/core/rendering/InlineFlowBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 6 chunks +5 lines, -19 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 9 chunks +10 lines, -83 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderInline.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ojan
The only thing that isn't a direct rename or dead code removal is the s/noOverflowRect/paddingBoxRect. ...
6 years, 1 month ago (2014-11-11 04:02:16 UTC) #2
esprehn
lgtm, I wonder what the reason for paddingBoxRect() and noOverflowRect() were on trunk.
6 years, 1 month ago (2014-11-11 18:11:11 UTC) #3
ojan
On 2014/11/11 at 18:11:11, esprehn wrote: > lgtm, I wonder what the reason for paddingBoxRect() ...
6 years, 1 month ago (2014-11-11 18:13:49 UTC) #4
ojan
6 years, 1 month ago (2014-11-11 18:16:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2e03574dce73775ae2870524575b4f86a2065ad6.

Powered by Google App Engine
This is Rietveld 408576698