sky/engine/core/rendering/RenderInline.cpp - Issue 691223003: Remove some more assorted code from RenderBox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderInline.cpp

Issue 691223003: Remove some more assorted code from RenderBox. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: merge to ToT Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderInline.cpp

diff --git a/sky/engine/core/rendering/RenderInline.cpp b/sky/engine/core/rendering/RenderInline.cpp

index ecb42f6789024b5a92abcc7b3d16aec0afaa02a6..add605f19688d2d02c4f805795667b60b0166ade 100644

--- a/sky/engine/core/rendering/RenderInline.cpp

+++ b/sky/engine/core/rendering/RenderInline.cpp

@@ -927,7 +927,7 @@ LayoutRect RenderInline::culledInlineVisualOverflowBoundingBox() const

if (curr->isBox()) {

RenderBox* currBox = toRenderBox(curr);

if (!currBox->hasSelfPaintingLayer() && currBox->inlineBoxWrapper()) {

- LayoutRect logicalRect = currBox->logicalVisualOverflowRectForPropagation(style());

+ LayoutRect logicalRect = currBox->visualOverflowRect();

logicalRect.moveBy(currBox->location());

result.uniteIfNonZero(logicalRect);

}